summaryrefslogtreecommitdiff
path: root/core/fxcrt
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-04-14 16:11:53 -0700
committerCommit bot <commit-bot@chromium.org>2016-04-14 16:11:53 -0700
commitc3dfb6bbc8763d972c3115fbf5a08f325f2d8960 (patch)
tree7bc37dee2eb6d7fb8e0d9cc7dde8df2bfb138447 /core/fxcrt
parent6f167c3ea2f8093170cae12a3de4ded76ac521ce (diff)
downloadpdfium-c3dfb6bbc8763d972c3115fbf5a08f325f2d8960.tar.xz
Update comments about string constructors
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1887003003
Diffstat (limited to 'core/fxcrt')
-rw-r--r--core/fxcrt/include/fx_string.h6
1 files changed, 5 insertions, 1 deletions
diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h
index 7024691e35..94df35c8e7 100644
--- a/core/fxcrt/include/fx_string.h
+++ b/core/fxcrt/include/fx_string.h
@@ -147,6 +147,7 @@ class CFX_ByteString {
CFX_ByteString(const CFX_ByteString& other) : m_pData(other.m_pData) {}
CFX_ByteString(CFX_ByteString&& other) { m_pData.Swap(other.m_pData); }
+ // Deliberately implicit to avoid calling on every string literal.
CFX_ByteString(char ch);
CFX_ByteString(const FX_CHAR* ptr)
: CFX_ByteString(ptr, ptr ? FXSYS_strlen(ptr) : 0) {}
@@ -154,6 +155,7 @@ class CFX_ByteString {
CFX_ByteString(const FX_CHAR* ptr, FX_STRSIZE len);
CFX_ByteString(const uint8_t* ptr, FX_STRSIZE len);
+ // TODO(tsepez): mark constructor as explicit.
CFX_ByteString(const CFX_ByteStringC& bstrc);
CFX_ByteString(const CFX_ByteStringC& bstrc1, const CFX_ByteStringC& bstrc2);
@@ -471,12 +473,14 @@ class CFX_WideString {
CFX_WideString(const CFX_WideString& other) : m_pData(other.m_pData) {}
CFX_WideString(CFX_WideString&& other) { m_pData.Swap(other.m_pData); }
+ // Deliberately implicit to avoid calling on every string literal.
+ CFX_WideString(FX_WCHAR ch);
CFX_WideString(const FX_WCHAR* ptr)
: CFX_WideString(ptr, ptr ? FXSYS_wcslen(ptr) : 0) {}
CFX_WideString(const FX_WCHAR* ptr, FX_STRSIZE len);
- CFX_WideString(FX_WCHAR ch);
+ // TODO(tsepez): mark constructor as explicit.
CFX_WideString(const CFX_WideStringC& str);
CFX_WideString(const CFX_WideStringC& str1, const CFX_WideStringC& str2);