Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calls to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.

Review URL: https://codereview.chromium.org/1870043003

2 files changed, 0 insertions, 18 deletions

diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp
index cc0dfe2341..34abe1e067 100644
--- a/core/fxcrt/fx_basic_bstring.cpp
+++ b/core/fxcrt/fx_basic_bstring.cpp
@@ -141,20 +141,6 @@ const CFX_ByteString& CFX_ByteString::operator=(
   return *this;
 }
 
-const CFX_ByteString& CFX_ByteString::operator=(const CFX_BinaryBuf& buf) {
-  Load(buf.GetBuffer(), buf.GetSize());
-  return *this;
-}
-
-void CFX_ByteString::Load(const uint8_t* buf, FX_STRSIZE len) {
-  if (!len) {
-    clear();
-    return;
-  }
-
-  m_pData.Reset(StringData::Create(reinterpret_cast<const FX_CHAR*>(buf), len));
-}
-
 const CFX_ByteString& CFX_ByteString::operator+=(const FX_CHAR* pStr) {
   if (pStr)
     Concat(pStr, FXSYS_strlen(pStr));
diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h
index 8a0b3ff3db..6e2954fcbb 100644
--- a/core/fxcrt/include/fx_string.h
+++ b/core/fxcrt/include/fx_string.h
@@ -15,7 +15,6 @@
 #include "core/fxcrt/include/fx_memory.h"
 #include "core/fxcrt/include/fx_system.h"
 
-class CFX_BinaryBuf;
 class CFX_ByteString;
 class CFX_WideString;
 
@@ -218,9 +217,6 @@ class CFX_ByteString {
   const CFX_ByteString& operator=(const FX_CHAR* str);
   const CFX_ByteString& operator=(const CFX_ByteStringC& bstrc);
   const CFX_ByteString& operator=(const CFX_ByteString& stringSrc);
-  const CFX_ByteString& operator=(const CFX_BinaryBuf& buf);
-
-  void Load(const uint8_t* str, FX_STRSIZE len);
 
   const CFX_ByteString& operator+=(FX_CHAR ch);
   const CFX_ByteString& operator+=(const FX_CHAR* str);