diff options
| author | Tom Sepez <tsepez@chromium.org> | 2016-03-24 10:43:11 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2016-03-24 10:43:11 -0700 |
| commit | 282cee1b5ef000c8b03f53f5cbb243893d4440d1 (patch) | |
| tree | 685106a00d32efdf59639babb9404d23f598d2b5 /core/fxcrt | |
| parent | 2e8798f5b93dac2fab4980b9c4862f13711809e6 (diff) | |
| download | pdfium-282cee1b5ef000c8b03f53f5cbb243893d4440d1.tar.xz | |
Remove strange integral constants for "true", "false", "%PDF".
Compilers have good inline memcmp nowadays, so we don't
have to resort to old tricks.
Remove FXDWORD_FROM_LSBFIRST and FXDWORD_FROM_MSBFIRST
while we're at it. MSBFIRST was technically wrong due
to promotion to int.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1834553002 .
Diffstat (limited to 'core/fxcrt')
| -rw-r--r-- | core/fxcrt/include/fx_system.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/core/fxcrt/include/fx_system.h b/core/fxcrt/include/fx_system.h index eb863c6048..1d51aec543 100644 --- a/core/fxcrt/include/fx_system.h +++ b/core/fxcrt/include/fx_system.h @@ -253,10 +253,6 @@ wchar_t* FXSYS_wcsupr(wchar_t* str); #define FXSYS_log10(a) (FX_FLOAT) log10(a) #define FXSYS_fmod(a, b) (FX_FLOAT) fmod(a, b) #define FXSYS_abs abs -#define FXDWORD_FROM_LSBFIRST(i) (i) -#define FXDWORD_FROM_MSBFIRST(i) \ - (((uint8_t)(i) << 24) | ((uint8_t)((i) >> 8) << 16) | \ - ((uint8_t)((i) >> 16) << 8) | (uint8_t)((i) >> 24)) #define FXDWORD_GET_LSBFIRST(p) \ ((static_cast<FX_DWORD>(p[3]) << 24) | (static_cast<FX_DWORD>(p[2]) << 16) | \ (static_cast<FX_DWORD>(p[1]) << 8) | (static_cast<FX_DWORD>(p[0]))) |