summaryrefslogtreecommitdiff
path: root/core/fxcrt
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2017-04-17 15:38:19 -0700
committerChromium commit bot <commit-bot@chromium.org>2017-04-18 17:17:36 +0000
commit3c3e271ea9fd19dd535a74b5546b27e3e82dcb81 (patch)
treee73049f2d18718da9ff8d42b46f31009c5e6e887 /core/fxcrt
parent94c5e25840046b7bf976d2d568e19ad63b656ade (diff)
downloadpdfium-3c3e271ea9fd19dd535a74b5546b27e3e82dcb81.tar.xz
Use Byte/WideString iterators
Change-Id: I85c8423c177fd7ecd5da90ef89419efc0f9cf44b Reviewed-on: https://pdfium-review.googlesource.com/4262 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt')
-rw-r--r--core/fxcrt/fx_bidi.cpp4
-rw-r--r--core/fxcrt/fx_extension.cpp16
2 files changed, 10 insertions, 10 deletions
diff --git a/core/fxcrt/fx_bidi.cpp b/core/fxcrt/fx_bidi.cpp
index 5ad6439e07..49333f6a76 100644
--- a/core/fxcrt/fx_bidi.cpp
+++ b/core/fxcrt/fx_bidi.cpp
@@ -52,8 +52,8 @@ CFX_BidiString::CFX_BidiString(const CFX_WideString& str)
: m_Str(str),
m_pBidiChar(new CFX_BidiChar),
m_eOverallDirection(CFX_BidiChar::LEFT) {
- for (int i = 0; i < m_Str.GetLength(); ++i) {
- if (m_pBidiChar->AppendChar(m_Str.GetAt(i)))
+ for (const auto& c : m_Str) {
+ if (m_pBidiChar->AppendChar(c))
m_Order.push_back(m_pBidiChar->GetSegmentInfo());
}
if (m_pBidiChar->EndChar())
diff --git a/core/fxcrt/fx_extension.cpp b/core/fxcrt/fx_extension.cpp
index acdce048e0..f3e72fd6df 100644
--- a/core/fxcrt/fx_extension.cpp
+++ b/core/fxcrt/fx_extension.cpp
@@ -509,11 +509,11 @@ int32_t FXSYS_strnicmp(const char* s1, const char* s2, size_t count) {
uint32_t FX_HashCode_GetA(const CFX_ByteStringC& str, bool bIgnoreCase) {
uint32_t dwHashCode = 0;
if (bIgnoreCase) {
- for (FX_STRSIZE i = 0; i < str.GetLength(); ++i)
- dwHashCode = 31 * dwHashCode + FXSYS_tolower(str.CharAt(i));
+ for (const auto& c : str)
+ dwHashCode = 31 * dwHashCode + FXSYS_tolower(c);
} else {
- for (FX_STRSIZE i = 0; i < str.GetLength(); ++i)
- dwHashCode = 31 * dwHashCode + str.CharAt(i);
+ for (const auto& c : str)
+ dwHashCode = 31 * dwHashCode + c;
}
return dwHashCode;
}
@@ -521,11 +521,11 @@ uint32_t FX_HashCode_GetA(const CFX_ByteStringC& str, bool bIgnoreCase) {
uint32_t FX_HashCode_GetW(const CFX_WideStringC& str, bool bIgnoreCase) {
uint32_t dwHashCode = 0;
if (bIgnoreCase) {
- for (FX_STRSIZE i = 0; i < str.GetLength(); ++i)
- dwHashCode = 1313 * dwHashCode + FXSYS_tolower(str.CharAt(i));
+ for (const auto& c : str)
+ dwHashCode = 1313 * dwHashCode + FXSYS_tolower(c);
} else {
- for (FX_STRSIZE i = 0; i < str.GetLength(); ++i)
- dwHashCode = 1313 * dwHashCode + str.CharAt(i);
+ for (const auto& c : str)
+ dwHashCode = 1313 * dwHashCode + c;
}
return dwHashCode;
}