summaryrefslogtreecommitdiff
path: root/core/fxcrt
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-09-17 18:25:32 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-09-17 18:25:32 +0000
commitcb798258c433bec7087948fcbfff14d1e7683006 (patch)
treebc873a405dbfe7c957d75a1748acce11c7f473e7 /core/fxcrt
parentc5709dd345c748016a637b2104544895223f8fc7 (diff)
downloadpdfium-cb798258c433bec7087948fcbfff14d1e7683006.tar.xz
Fix final/protected conflicts.
Classes marked |final| should not have |protected| members. In turn, "private field m_dwEncryptObjNum is not used" warning is produced. Change-Id: I51a96aca5a5f499381a6764d892962f7f2dc0327 Reviewed-on: https://pdfium-review.googlesource.com/42611 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt')
-rw-r--r--core/fxcrt/cfx_fileaccess_posix.h2
-rw-r--r--core/fxcrt/cfx_fileaccess_windows.h2
-rw-r--r--core/fxcrt/css/cfx_cssvaluelist.h2
3 files changed, 3 insertions, 3 deletions
diff --git a/core/fxcrt/cfx_fileaccess_posix.h b/core/fxcrt/cfx_fileaccess_posix.h
index 7b8230de18..c759d8c1aa 100644
--- a/core/fxcrt/cfx_fileaccess_posix.h
+++ b/core/fxcrt/cfx_fileaccess_posix.h
@@ -37,7 +37,7 @@ class CFX_FileAccess_Posix final : public FileAccessIface {
bool Flush() override;
bool Truncate(FX_FILESIZE szFile) override;
- protected:
+ private:
int32_t m_nFD;
};
diff --git a/core/fxcrt/cfx_fileaccess_windows.h b/core/fxcrt/cfx_fileaccess_windows.h
index fad2ed6f94..6d58409e65 100644
--- a/core/fxcrt/cfx_fileaccess_windows.h
+++ b/core/fxcrt/cfx_fileaccess_windows.h
@@ -35,7 +35,7 @@ class CFX_FileAccess_Windows final : public FileAccessIface {
bool Flush() override;
bool Truncate(FX_FILESIZE szFile) override;
- protected:
+ private:
void* m_hFile;
};
diff --git a/core/fxcrt/css/cfx_cssvaluelist.h b/core/fxcrt/css/cfx_cssvaluelist.h
index 5e04c649b9..4b87f4c381 100644
--- a/core/fxcrt/css/cfx_cssvaluelist.h
+++ b/core/fxcrt/css/cfx_cssvaluelist.h
@@ -19,7 +19,7 @@ class CFX_CSSValueList final : public CFX_CSSValue {
int32_t CountValues() const;
RetainPtr<CFX_CSSValue> GetValue(int32_t index) const;
- protected:
+ private:
std::vector<RetainPtr<CFX_CSSValue>> m_ppList;
};