diff options
| author | Nicolas Pena <npm@chromium.org> | 2017-06-29 17:02:48 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-06-29 21:54:18 +0000 |
| commit | caf6d61fbb38083f213a9d3441e12c5082d3ad3a (patch) | |
| tree | ddfaf73e97af75ac862dddc34b47603d5492cfa1 /core/fxge/agg | |
| parent | cd984752d05a58c0bd6f8ddd740d5cd4bfca20c6 (diff) | |
| download | pdfium-caf6d61fbb38083f213a9d3441e12c5082d3ad3a.tar.xz | |
Move Start to constructor in CFX_Image(Renderer|Transformer)chromium/3145
The bool returned by Start was not being used and the method was always
called right after the constructor, so it should be in the constructor.
Change-Id: I98abf9f7c11fbe42b3aa15ec5e46731198aa23d5
Reviewed-on: https://pdfium-review.googlesource.com/7151
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxge/agg')
| -rw-r--r-- | core/fxge/agg/fx_agg_driver.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp index 91272d4427..855ea2a04c 100644 --- a/core/fxge/agg/fx_agg_driver.cpp +++ b/core/fxge/agg/fx_agg_driver.cpp @@ -1546,9 +1546,9 @@ bool CFX_AggDeviceDriver::StartDIBits( if (!m_pBitmap->GetBuffer()) return true; - *handle = pdfium::MakeUnique<CFX_ImageRenderer>(); - (*handle)->Start(m_pBitmap, m_pClipRgn.get(), pSource, bitmap_alpha, argb, - pMatrix, render_flags, m_bRgbByteOrder); + *handle = pdfium::MakeUnique<CFX_ImageRenderer>( + m_pBitmap, m_pClipRgn.get(), pSource, bitmap_alpha, argb, pMatrix, + render_flags, m_bRgbByteOrder); return true; } |