diff options
| author | caryclark <caryclark@google.com> | 2016-11-21 04:41:31 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-21 04:41:31 -0800 |
| commit | a1053a07ab1fe8c799acb4a46a61588616d85c5a (patch) | |
| tree | 4a3bbe412b118ec1c206d782ea3b999c7c0f0323 /core/fxge/cfx_facecache.h | |
| parent | d8f710cedd62c1d28beee15d7dc3d31ddd148437 (diff) | |
| download | pdfium-a1053a07ab1fe8c799acb4a46a61588616d85c5a.tar.xz | |
use skia text
This adds text to the _SUPPORT_SKIA_PATHS_
variant.
The output of the test corpus has more
differences, but no feature changes or
dropouts that I can see.
The text is a bit lighter. Bungeman thinks
this is because of our support of SRGB
color, although the fonts also look different
so maybe there's more to the story.
The output looks compatible with the
variations I see in Adobe Reader and Firefox
on the same platform.
There's probably more text tuning to do.
Additionally, this turns off the caching
feature for this variation. Caching can't
work because the drawing alternates between
Skia and PDFium's native blits, so any
state caching won't know about changes
and drawing performed by the other.
R=dsinclair@chromium.org, bungeman@chromium.org
Review-Url: https://codereview.chromium.org/2520483002
Diffstat (limited to 'core/fxge/cfx_facecache.h')
| -rw-r--r-- | core/fxge/cfx_facecache.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fxge/cfx_facecache.h b/core/fxge/cfx_facecache.h index 96fc73b57d..60528ba6a5 100644 --- a/core/fxge/cfx_facecache.h +++ b/core/fxge/cfx_facecache.h @@ -27,7 +27,7 @@ class CFX_FaceCache { uint32_t glyph_index, int dest_width); -#ifdef _SKIA_SUPPORT_ +#if defined _SKIA_SUPPORT_ || _SKIA_SUPPORT_PATHS_ CFX_TypeFace* GetDeviceCache(const CFX_Font* pFont); #endif @@ -56,7 +56,7 @@ class CFX_FaceCache { FXFT_Face const m_Face; std::map<CFX_ByteString, std::unique_ptr<CFX_SizeGlyphCache>> m_SizeMap; std::map<uint32_t, std::unique_ptr<CFX_PathData>> m_PathMap; -#ifdef _SKIA_SUPPORT_ +#if defined _SKIA_SUPPORT_ || _SKIA_SUPPORT_PATHS_ CFX_TypeFace* m_pTypeface; #endif }; |