summaryrefslogtreecommitdiff
path: root/core/fxge/cfx_fontmgr.h
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2017-11-21 22:07:50 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-21 22:07:50 +0000
commit56e04d2656bdd5f2b9448d857e8e73ab16aadf8e (patch)
tree57ed8ebed62f498bdd1fe010b0909f162bbcd29c /core/fxge/cfx_fontmgr.h
parentebe865db548f768038186054fc0f1eb024565c43 (diff)
downloadpdfium-56e04d2656bdd5f2b9448d857e8e73ab16aadf8e.tar.xz
Avoid passing pointers by reference in core.
This gets rid of most core/ non-const ref passing, either by passing by pointer-to-pointer instead, or by returning std::pair. Change-Id: Id7bdc355a1a725a05f9fa2f1e982ca8c975beef1 Reviewed-on: https://pdfium-review.googlesource.com/19030 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fxge/cfx_fontmgr.h')
-rw-r--r--core/fxge/cfx_fontmgr.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fxge/cfx_fontmgr.h b/core/fxge/cfx_fontmgr.h
index eddb1efd56..62ecd84716 100644
--- a/core/fxge/cfx_fontmgr.h
+++ b/core/fxge/cfx_fontmgr.h
@@ -27,7 +27,7 @@ class CFX_FontMgr {
FXFT_Face GetCachedFace(const ByteString& face_name,
int weight,
bool bItalic,
- uint8_t*& pFontData);
+ uint8_t** pFontData);
FXFT_Face AddCachedFace(const ByteString& face_name,
int weight,
bool bItalic,
@@ -37,7 +37,7 @@ class CFX_FontMgr {
FXFT_Face GetCachedTTCFace(int ttc_size,
uint32_t checksum,
int font_offset,
- uint8_t*& pFontData);
+ uint8_t** pFontData);
FXFT_Face AddCachedTTCFace(int ttc_size,
uint32_t checksum,
uint8_t* pData,