diff options
| author | Nicolas Pena <npm@chromium.org> | 2017-04-07 14:12:31 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-07 18:29:13 +0000 |
| commit | 6a5c20cd08748da5969cbab756c3e8a6dd27bfbc (patch) | |
| tree | 09a5d7e2666b166dc55e94a48270f17741d22b22 /core/fxge/dib/cfx_bitmapcomposer.h | |
| parent | 1e8c39f18df6e597e079cce13d18d72631ef0fb9 (diff) | |
| download | pdfium-6a5c20cd08748da5969cbab756c3e8a6dd27bfbc.tar.xz | |
Remove the ICC transform where it is never initialized.
- All callers of CFX_DIBitmap methods use nullptr as the ICC Transform.
- The CFX_ScanlineCompositor is always initialized with a null ICC transform.
Many of its methods call TranslateScanline from the ICC module. This method
casts just uses ((CLcmsCmm*)pTransform)->m_hTransform, and this should not be
done when pTransform is nullptr.
Change-Id: I1b846d1f20699fa017cb9a276be3214eb8fabd4b
Reviewed-on: https://pdfium-review.googlesource.com/3931
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxge/dib/cfx_bitmapcomposer.h')
| -rw-r--r-- | core/fxge/dib/cfx_bitmapcomposer.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/core/fxge/dib/cfx_bitmapcomposer.h b/core/fxge/dib/cfx_bitmapcomposer.h index 5ab0647478..6e961cbd45 100644 --- a/core/fxge/dib/cfx_bitmapcomposer.h +++ b/core/fxge/dib/cfx_bitmapcomposer.h @@ -32,7 +32,6 @@ class CFX_BitmapComposer : public IFX_ScanlineComposer { bool bFlipY, bool bRgbByteOrder, int alpha_flag, - void* pIccTransform, int blend_type); // IFX_ScanlineComposer @@ -71,7 +70,6 @@ class CFX_BitmapComposer : public IFX_ScanlineComposer { bool m_bFlipX; bool m_bFlipY; int m_AlphaFlag; - void* m_pIccTransform; bool m_bRgbByteOrder; int m_BlendType; std::vector<uint8_t> m_pScanlineV; |