Remove the ICC transform where it is never initialized.

- All callers of CFX_DIBitmap methods use nullptr as the ICC Transform.
- The CFX_ScanlineCompositor is always initialized with a null ICC transform.
Many of its methods call TranslateScanline from the ICC module. This method
casts just uses ((CLcmsCmm*)pTransform)->m_hTransform, and this should not be
done when pTransform is nullptr.

Change-Id: I1b846d1f20699fa017cb9a276be3214eb8fabd4b
Reviewed-on: https://pdfium-review.googlesource.com/3931
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

1 files changed, 1 insertions, 5 deletions

diff --git a/core/fxge/dib/cfx_imagerenderer.h b/core/fxge/dib/cfx_imagerenderer.h
index db8bd08638..f3d1286dc6 100644
--- a/core/fxge/dib/cfx_imagerenderer.h
+++ b/core/fxge/dib/cfx_imagerenderer.h
@@ -32,10 +32,7 @@ class CFX_ImageRenderer {
              uint32_t mask_color,
              const CFX_Matrix* pMatrix,
              uint32_t dib_flags,
-             bool bRgbByteOrder = false,
-             int alpha_flag = 0,
-             void* pIccTransform = nullptr,
-             int blend_type = FXDIB_BLEND_NORMAL);
+             bool bRgbByteOrder);
 
   bool Continue(IFX_Pause* pPause);
 
@@ -52,7 +49,6 @@ class CFX_ImageRenderer {
   FX_RECT m_ClipBox;
   uint32_t m_Flags;
   int m_AlphaFlag;
-  void* m_pIccTransform;
   bool m_bRgbByteOrder;
   int m_BlendType;
 };