diff options
author | ochang <ochang@chromium.org> | 2016-04-11 13:47:41 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-04-11 13:47:41 -0700 |
commit | b8627c9d13884d48943d8a7a5381eaf0bb2c08d9 (patch) | |
tree | 8357843404f8bea28b7930acb888eb853d822a9a /core/fxge/ge/fx_ge_text_embeddertest.cpp | |
parent | 184b82553000a41fd0c90be56fa2f1c1503e2e9e (diff) | |
download | pdfium-b8627c9d13884d48943d8a7a5381eaf0bb2c08d9.tar.xz |
Fix integer issues leading to out of bounds access in fx_ge_text.cpp.
- Using |-skew| to get positive index, which doesn't work when skew is
INT_MIN
- Incorrect logic when determining when to use |-skew| as an index.
R=tsepez@chromium.org,weili@chromium.org
BUG=chromium:601362
Review URL: https://codereview.chromium.org/1875673004
Diffstat (limited to 'core/fxge/ge/fx_ge_text_embeddertest.cpp')
-rw-r--r-- | core/fxge/ge/fx_ge_text_embeddertest.cpp | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/core/fxge/ge/fx_ge_text_embeddertest.cpp b/core/fxge/ge/fx_ge_text_embeddertest.cpp new file mode 100644 index 0000000000..045b6dc869 --- /dev/null +++ b/core/fxge/ge/fx_ge_text_embeddertest.cpp @@ -0,0 +1,18 @@ +// Copyright 2016 PDFium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "testing/embedder_test.h" +#include "testing/gtest/include/gtest/gtest.h" + +class FXGETextEmbedderTest : public EmbedderTest {}; + +TEST_F(FXGETextEmbedderTest, BadItalic) { + // Shouldn't crash. + EXPECT_TRUE(OpenDocument("bug_601362.pdf")); + FPDF_PAGE page = LoadPage(0); + EXPECT_NE(nullptr, page); + FPDF_BITMAP bitmap = RenderPage(page); + FPDFBitmap_Destroy(bitmap); + UnloadPage(page); +} |