summaryrefslogtreecommitdiff
path: root/core/fxge/ge
diff options
context:
space:
mode:
authornpm <npm@chromium.org>2016-09-12 13:38:52 -0700
committerCommit bot <commit-bot@chromium.org>2016-09-12 13:38:52 -0700
commit01b67ed9b441cd485997bc08482def1f2ab265db (patch)
treeba045b2659de3d41a1fedf285a4a49bc5134b435 /core/fxge/ge
parent56cf519689846dd03a381fb6c4e7a054effdd20b (diff)
downloadpdfium-01b67ed9b441cd485997bc08482def1f2ab265db.tar.xz
Refactor CPDF_Document by creating new methods
- Methods GetPagesDict, ProcessNonbCJK, CalculateFlags, and CalculateEncodingDict created to reduce duplicated code. - Code nits Review-Url: https://codereview.chromium.org/2323793003
Diffstat (limited to 'core/fxge/ge')
-rw-r--r--core/fxge/ge/cfx_font.cpp27
1 files changed, 12 insertions, 15 deletions
diff --git a/core/fxge/ge/cfx_font.cpp b/core/fxge/ge/cfx_font.cpp
index 3d2e6d6499..feea8b0aa1 100644
--- a/core/fxge/ge/cfx_font.cpp
+++ b/core/fxge/ge/cfx_font.cpp
@@ -446,30 +446,27 @@ FX_BOOL CFX_Font::GetGlyphBBox(uint32_t glyph_index, FX_RECT& bbox) {
return TRUE;
}
-FX_BOOL CFX_Font::IsItalic() const {
+bool CFX_Font::IsItalic() const {
if (!m_Face)
- return FALSE;
+ return false;
- FX_BOOL ret = FXFT_Is_Face_Italic(m_Face) == FXFT_STYLE_FLAG_ITALIC;
- if (!ret) {
- CFX_ByteString str(FXFT_Get_Face_Style_Name(m_Face));
- str.MakeLower();
- if (str.Find("italic") != -1)
- ret = TRUE;
- }
- return ret;
+ if (FXFT_Is_Face_Italic(m_Face) == FXFT_STYLE_FLAG_ITALIC)
+ return true;
+ CFX_ByteString str(FXFT_Get_Face_Style_Name(m_Face));
+ str.MakeLower();
+ return str.Find("italic") != -1;
}
-FX_BOOL CFX_Font::IsBold() const {
+bool CFX_Font::IsBold() const {
if (!m_Face)
- return FALSE;
+ return false;
return FXFT_Is_Face_Bold(m_Face) == FXFT_STYLE_FLAG_BOLD;
}
-FX_BOOL CFX_Font::IsFixedWidth() const {
+bool CFX_Font::IsFixedWidth() const {
if (!m_Face)
- return FALSE;
- return FXFT_Is_Face_fixedwidth(m_Face);
+ return false;
+ return FXFT_Is_Face_fixedwidth(m_Face) != 0;
}
CFX_ByteString CFX_Font::GetPsName() const {