fix paths and remove dead code

More Skia driver cleanup.

Fix the GN build for Skia.
Remove unused functions from header.
Remove agg setup that is not required.

Change path construction to use the SkCanvas matrix to position the path
rather than converting the points directly.

Draw stroked paths using Skia rather than generated the filled path.
Pin the minimum stroke width to 1 px in device space to mimic PDF's stroke
dropout control.

Factor out flipped and non-flipped matrices.

Add some debugging code.

Set the bitmap filter quality to high. This helps a lot with 1 bit sources.

R=dsinclair@chromium.org, dsinclair, tsepez

Review URL: https://codereview.chromium.org/1806843002 .

1 files changed, 2 insertions, 15 deletions

diff --git a/core/fxge/skia/fx_skia_device.h b/core/fxge/skia/fx_skia_device.h
index 7d266d39b2..8a92f37e34 100644
--- a/core/fxge/skia/fx_skia_device.h
+++ b/core/fxge/skia/fx_skia_device.h
@@ -8,6 +8,7 @@
 #if defined(_SKIA_SUPPORT_)
 
 class SkCanvas;
+class SkMatrix;
 class SkPaint;
 class SkPath;
 class SkPictureRecorder;
@@ -56,12 +57,6 @@ class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver {
                    void* pIccTransform = NULL,
                    int blend_type = FXDIB_BLEND_NORMAL) override;
 
-  FX_BOOL SetPixel(int x,
-                   int y,
-                   FX_DWORD color,
-                   int alpha_flag = 0,
-                   void* pIccTransform = NULL) override;
-
   FX_BOOL FillRect(const FX_RECT* pRect,
                    FX_DWORD fill_color,
                    int alpha_flag = 0,
@@ -133,16 +128,8 @@ class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver {
                          int alpha_flag = 0,
                          void* pIccTransform = NULL) override;
 
-  FX_BOOL RenderRasterizer(agg::rasterizer_scanline_aa& rasterizer,
-                           FX_DWORD color,
-                           FX_BOOL bFullCover,
-                           FX_BOOL bGroupKnockout,
-                           int alpha_flag,
-                           void* pIccTransform);
-  void SetClipMask(agg::rasterizer_scanline_aa& rasterizer);
-  void SetClipMask(SkPath& skPath, SkPaint* spaint);
   virtual uint8_t* GetBuffer() const { return m_pAggDriver->GetBuffer(); }
-  void PaintStroke(SkPaint* spaint, const CFX_GraphStateData* pGraphState);
+  void PaintStroke(SkPaint* spaint, const CFX_GraphStateData* pGraphState, const SkMatrix& matrix);
   SkPictureRecorder* GetRecorder() const { return m_pRecorder; }
 
  private: