diff options
| author | caryclark <caryclark@google.com> | 2016-11-17 17:28:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-17 17:28:10 -0800 |
| commit | 0201377b6c4bb3b73f2564092426f3962a0bd9ed (patch) | |
| tree | 0ae87fde5a65d60505df0b64f993bf990e680dfc /core/fxge/skia/fx_skia_device.h | |
| parent | c892d24abf5704bc795a0a1a4c5dd2356aa61f35 (diff) | |
| download | pdfium-0201377b6c4bb3b73f2564092426f3962a0bd9ed.tar.xz | |
fix corpus tests
All corpus tests draw reasonably well.
There are pixel differences, but no missing
features or large scale errors.
This was verified by running run_corpus_tests.py
on skiapaths and agg build dirs, then running
the skdiff tool to generate a report of the
pixel difference. For example, after running
$ ninja -C out/skia skdiff
$ ./out/skia/skdiff /repo/pdfium/out/agg/gen/pdfium/testing/corpus/ /repo/pdfium/out/skiapaths/gen/pdfium/testing/corpus/ ~/aggskiadiffs
view the report in a browser at ~/aggskiadiffs/index.html
R=dsinclair@chromium.org
BUG=skia:5973
Review-Url: https://codereview.chromium.org/2504863003
Diffstat (limited to 'core/fxge/skia/fx_skia_device.h')
| -rw-r--r-- | core/fxge/skia/fx_skia_device.h | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/core/fxge/skia/fx_skia_device.h b/core/fxge/skia/fx_skia_device.h index ca5707c41a..e14ea7c458 100644 --- a/core/fxge/skia/fx_skia_device.h +++ b/core/fxge/skia/fx_skia_device.h @@ -93,7 +93,9 @@ class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver { int dest_top, int bitmap_alpha, int blend_type) override; -#else +#endif + +#ifdef _SKIA_SUPPORT_PATHS_ void SetClipMask(const FX_RECT& clipBox, const SkPath& skClipPath); #endif @@ -149,6 +151,10 @@ class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver { void Flush(); SkPictureRecorder* GetRecorder() const { return m_pRecorder; } static void PreMultiply(CFX_DIBitmap* pDIBitmap); +#ifdef _SKIA_SUPPORT_PATHS_ + void UnPreMultiplyDevice(); + void UnPreMultiply(CFX_DIBitmap* pDIBitmap); +#endif SkCanvas* SkiaCanvas() { return m_pCanvas; } void DebugVerifyBitmapIsPreMultiplied() const; void Dump() const; @@ -161,7 +167,7 @@ class CFX_SkiaDeviceDriver : public IFX_RenderDeviceDriver { SkCanvas* m_pCanvas; SkPictureRecorder* const m_pRecorder; std::unique_ptr<SkiaState> m_pCache; -#ifndef _SKIA_SUPPORT_ +#ifdef _SKIA_SUPPORT_PATHS_ std::unique_ptr<CFX_ClipRgn> m_pClipRgn; std::vector<std::unique_ptr<CFX_ClipRgn>> m_StateStack; int m_FillFlags; |