summaryrefslogtreecommitdiff
path: root/core/fxge
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-10-27 12:57:52 -0700
committerCommit bot <commit-bot@chromium.org>2016-10-27 12:57:52 -0700
commit5c15e67e12e245d102a2e0ef1b4ade54379f252c (patch)
tree0d26b2039eae74fa403256469b3eb15b7553e081 /core/fxge
parentaeab530b04938797a3fda138a6f25939a26e41d4 (diff)
downloadpdfium-5c15e67e12e245d102a2e0ef1b4ade54379f252c.tar.xz
Fix some FX_BOOL / int noise in core/fx*chromium/2903
Review-Url: https://codereview.chromium.org/2459673002
Diffstat (limited to 'core/fxge')
-rw-r--r--core/fxge/agg/fx_agg_driver.cpp34
-rw-r--r--core/fxge/ge/cfx_renderdevice.cpp2
2 files changed, 16 insertions, 20 deletions
diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp
index d3be763def..ed6410b4c3 100644
--- a/core/fxge/agg/fx_agg_driver.cpp
+++ b/core/fxge/agg/fx_agg_driver.cpp
@@ -240,7 +240,7 @@ FX_BOOL DibSetPixel(CFX_DIBitmap* pDevice,
uint32_t color,
int alpha_flag,
void* pIccTransform) {
- FX_BOOL bObjCMYK = FXGETFLAG_COLORTYPE(alpha_flag);
+ FX_BOOL bObjCMYK = !!FXGETFLAG_COLORTYPE(alpha_flag);
int alpha = bObjCMYK ? FXGETFLAG_ALPHA_FILL(alpha_flag) : FXARGB_A(color);
if (pIccTransform) {
CCodec_IccModule* pIccModule =
@@ -1315,7 +1315,7 @@ class CFX_Renderer {
m_pClipMask = m_pClipRgn->GetMask().GetObject();
}
m_bFullCover = bFullCover;
- FX_BOOL bObjectCMYK = FXGETFLAG_COLORTYPE(alpha_flag);
+ FX_BOOL bObjectCMYK = !!FXGETFLAG_COLORTYPE(alpha_flag);
FX_BOOL bDeviceCMYK = pDevice->IsCmykImage();
m_Alpha = bObjectCMYK ? FXGETFLAG_ALPHA_FILL(alpha_flag) : FXARGB_A(color);
CCodec_IccModule* pIccModule = nullptr;
@@ -1468,8 +1468,9 @@ FX_BOOL CFX_AggDeviceDriver::DrawPath(const CFX_PathData* pPathData,
rasterizer.filling_rule((fill_mode & 3) == FXFILL_WINDING
? agg::fill_non_zero
: agg::fill_even_odd);
- if (!RenderRasterizer(rasterizer, fill_color, fill_mode & FXFILL_FULLCOVER,
- FALSE, 0, nullptr)) {
+ if (!RenderRasterizer(rasterizer, fill_color,
+ !!(fill_mode & FXFILL_FULLCOVER), FALSE, 0,
+ nullptr)) {
return FALSE;
}
}
@@ -1484,13 +1485,10 @@ FX_BOOL CFX_AggDeviceDriver::DrawPath(const CFX_PathData* pPathData,
rasterizer.clip_box(0.0f, 0.0f, (FX_FLOAT)(GetDeviceCaps(FXDC_PIXEL_WIDTH)),
(FX_FLOAT)(GetDeviceCaps(FXDC_PIXEL_HEIGHT)));
RasterizeStroke(rasterizer, path_data.m_PathData, nullptr, pGraphState, 1,
- FALSE, fill_mode & FX_STROKE_TEXT_MODE);
- if (!RenderRasterizer(rasterizer, stroke_color,
- fill_mode & FXFILL_FULLCOVER, m_bGroupKnockout, 0,
- nullptr)) {
- return FALSE;
- }
- return TRUE;
+ FALSE, !!(fill_mode & FX_STROKE_TEXT_MODE));
+ return RenderRasterizer(rasterizer, stroke_color,
+ !!(fill_mode & FXFILL_FULLCOVER), m_bGroupKnockout,
+ 0, nullptr);
}
CFX_Matrix matrix1;
CFX_Matrix matrix2;
@@ -1512,12 +1510,10 @@ FX_BOOL CFX_AggDeviceDriver::DrawPath(const CFX_PathData* pPathData,
rasterizer.clip_box(0.0f, 0.0f, (FX_FLOAT)(GetDeviceCaps(FXDC_PIXEL_WIDTH)),
(FX_FLOAT)(GetDeviceCaps(FXDC_PIXEL_HEIGHT)));
RasterizeStroke(rasterizer, path_data.m_PathData, &matrix2, pGraphState,
- matrix1.a, FALSE, fill_mode & FX_STROKE_TEXT_MODE);
- if (!RenderRasterizer(rasterizer, stroke_color, fill_mode & FXFILL_FULLCOVER,
- m_bGroupKnockout, 0, nullptr)) {
- return FALSE;
- }
- return TRUE;
+ matrix1.a, FALSE, !!(fill_mode & FX_STROKE_TEXT_MODE));
+ return RenderRasterizer(rasterizer, stroke_color,
+ !!(fill_mode & FXFILL_FULLCOVER), m_bGroupKnockout, 0,
+ nullptr);
}
FX_BOOL CFX_AggDeviceDriver::SetPixel(int x, int y, uint32_t color) {
@@ -1752,8 +1748,8 @@ bool CFX_FxgeDevice::Create(int width,
return false;
}
SetBitmap(pBitmap);
- SetDeviceDriver(pdfium::MakeUnique<CFX_AggDeviceDriver>(pBitmap, FALSE,
- pOriDevice, FALSE));
+ SetDeviceDriver(pdfium::MakeUnique<CFX_AggDeviceDriver>(pBitmap, false,
+ pOriDevice, false));
return true;
}
diff --git a/core/fxge/ge/cfx_renderdevice.cpp b/core/fxge/ge/cfx_renderdevice.cpp
index 0ee99947a4..1c3611ed9b 100644
--- a/core/fxge/ge/cfx_renderdevice.cpp
+++ b/core/fxge/ge/cfx_renderdevice.cpp
@@ -532,7 +532,7 @@ FX_BOOL CFX_RenderDevice::DrawPathWithBlend(
CFX_PathData newPath;
FX_BOOL bThin = FALSE;
if (pPathData->GetZeroAreaPath(newPath, (CFX_Matrix*)pObject2Device, bThin,
- m_pDeviceDriver->GetDriverType())) {
+ !!m_pDeviceDriver->GetDriverType())) {
CFX_GraphStateData graphState;
graphState.m_LineWidth = 0.0f;
uint32_t strokecolor = fill_color;