diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
---|---|---|
committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
tree | e727d747684b9db2632ef250b55046cfce2b55a3 /core/fxge | |
parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxge')
-rw-r--r-- | core/fxge/agg/fx_agg_driver.cpp | 1 | ||||
-rw-r--r-- | core/fxge/apple/fx_mac_imp.cpp | 2 | ||||
-rw-r--r-- | core/fxge/cfx_facecache.h | 1 | ||||
-rw-r--r-- | core/fxge/cfx_fontmapper.h | 1 | ||||
-rw-r--r-- | core/fxge/dib/fx_dib_convert.cpp | 3 | ||||
-rw-r--r-- | core/fxge/dib/fx_dib_main.cpp | 3 | ||||
-rw-r--r-- | core/fxge/dib/fx_dib_transform.cpp | 3 | ||||
-rw-r--r-- | core/fxge/fx_font.h | 2 | ||||
-rw-r--r-- | core/fxge/ge/cfx_facecache.cpp | 2 | ||||
-rw-r--r-- | core/fxge/ge/cfx_folderfontinfo.cpp | 2 | ||||
-rw-r--r-- | core/fxge/ge/cfx_font.cpp | 6 | ||||
-rw-r--r-- | core/fxge/ge/cfx_fontcache.cpp | 3 | ||||
-rw-r--r-- | core/fxge/ge/cfx_fontmgr.cpp | 3 | ||||
-rw-r--r-- | core/fxge/ge/cfx_renderdevice.cpp | 5 | ||||
-rw-r--r-- | core/fxge/ge/fx_ge_fontmap.cpp | 2 | ||||
-rw-r--r-- | core/fxge/ifx_systemfontinfo.h | 2 | ||||
-rw-r--r-- | core/fxge/skia/fx_skia_device.cpp | 1 | ||||
-rw-r--r-- | core/fxge/skia/fx_skia_device.h | 3 |
18 files changed, 45 insertions, 0 deletions
diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp index 3634d96d91..e341e8c045 100644 --- a/core/fxge/agg/fx_agg_driver.cpp +++ b/core/fxge/agg/fx_agg_driver.cpp @@ -7,6 +7,7 @@ #include "core/fxge/agg/fx_agg_driver.h" #include <algorithm> +#include <utility> #include "core/fxcodec/fx_codec.h" #include "core/fxcrt/fx_memory.h" diff --git a/core/fxge/apple/fx_mac_imp.cpp b/core/fxge/apple/fx_mac_imp.cpp index 7c3cb04105..c05aea34f5 100644 --- a/core/fxge/apple/fx_mac_imp.cpp +++ b/core/fxge/apple/fx_mac_imp.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <memory> + #include "core/fxge/apple/apple_int.h" #include "core/fxge/cfx_gemodule.h" #include "core/fxge/ge/cfx_folderfontinfo.h" diff --git a/core/fxge/cfx_facecache.h b/core/fxge/cfx_facecache.h index 60528ba6a5..44ed0b287a 100644 --- a/core/fxge/cfx_facecache.h +++ b/core/fxge/cfx_facecache.h @@ -8,6 +8,7 @@ #define CORE_FXGE_CFX_FACECACHE_H_ #include <map> +#include <memory> #include "core/fxge/fx_font.h" #include "core/fxge/fx_freetype.h" diff --git a/core/fxge/cfx_fontmapper.h b/core/fxge/cfx_fontmapper.h index fa3bc02eb0..96630a77df 100644 --- a/core/fxge/cfx_fontmapper.h +++ b/core/fxge/cfx_fontmapper.h @@ -8,6 +8,7 @@ #define CORE_FXGE_CFX_FONTMAPPER_H_ #include <memory> +#include <utility> #include <vector> #include "core/fxge/cfx_fontmgr.h" diff --git a/core/fxge/dib/fx_dib_convert.cpp b/core/fxge/dib/fx_dib_convert.cpp index 5eac2ac8e4..f5ae563d57 100644 --- a/core/fxge/dib/fx_dib_convert.cpp +++ b/core/fxge/dib/fx_dib_convert.cpp @@ -4,6 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <memory> +#include <utility> + #include "core/fxcodec/fx_codec.h" #include "core/fxge/fx_dib.h" diff --git a/core/fxge/dib/fx_dib_main.cpp b/core/fxge/dib/fx_dib_main.cpp index 9c91c74366..63db7adb91 100644 --- a/core/fxge/dib/fx_dib_main.cpp +++ b/core/fxge/dib/fx_dib_main.cpp @@ -7,7 +7,10 @@ #include "core/fxge/fx_dib.h" #include <limits.h> + #include <algorithm> +#include <memory> +#include <utility> #include "core/fxcodec/fx_codec.h" #include "core/fxge/cfx_gemodule.h" diff --git a/core/fxge/dib/fx_dib_transform.cpp b/core/fxge/dib/fx_dib_transform.cpp index e2b95237d5..b938d648a8 100644 --- a/core/fxge/dib/fx_dib_transform.cpp +++ b/core/fxge/dib/fx_dib_transform.cpp @@ -6,6 +6,9 @@ #include "core/fxge/dib/dib_int.h" +#include <memory> +#include <utility> + #include "core/fxge/fx_dib.h" #include "third_party/base/ptr_util.h" diff --git a/core/fxge/fx_font.h b/core/fxge/fx_font.h index c0d204199c..6bb4bdea34 100644 --- a/core/fxge/fx_font.h +++ b/core/fxge/fx_font.h @@ -8,6 +8,7 @@ #define CORE_FXGE_FX_FONT_H_ #include <memory> +#include <utility> #include <vector> #include "core/fxcrt/fx_system.h" @@ -169,6 +170,7 @@ class CFX_Font { static const uint8_t s_WeightPow_SHIFTJIS[kWeightPowArraySize]; #ifdef PDF_ENABLE_XFA + protected: CFX_BinaryBuf m_OtfFontData; bool m_bShallowCopy; diff --git a/core/fxge/ge/cfx_facecache.cpp b/core/fxge/ge/cfx_facecache.cpp index 942814b75a..cbaa07e449 100644 --- a/core/fxge/ge/cfx_facecache.cpp +++ b/core/fxge/ge/cfx_facecache.cpp @@ -7,6 +7,8 @@ #include "core/fxge/cfx_facecache.h" #include <algorithm> +#include <limits> +#include <memory> #include "core/fxge/cfx_fontmgr.h" #include "core/fxge/cfx_gemodule.h" diff --git a/core/fxge/ge/cfx_folderfontinfo.cpp b/core/fxge/ge/cfx_folderfontinfo.cpp index 9ccccbc635..776a37319b 100644 --- a/core/fxge/ge/cfx_folderfontinfo.cpp +++ b/core/fxge/ge/cfx_folderfontinfo.cpp @@ -6,6 +6,8 @@ #include "core/fxge/ge/cfx_folderfontinfo.h" +#include <limits> + #include "core/fxge/cfx_fontmapper.h" #include "core/fxge/fx_font.h" diff --git a/core/fxge/ge/cfx_font.cpp b/core/fxge/ge/cfx_font.cpp index b778031606..b85709040b 100644 --- a/core/fxge/ge/cfx_font.cpp +++ b/core/fxge/ge/cfx_font.cpp @@ -6,6 +6,12 @@ #include "core/fxge/fx_font.h" +#include <algorithm> +#include <limits> +#include <memory> +#include <utility> +#include <vector> + #include "core/fpdfapi/font/cpdf_font.h" #include "core/fxge/cfx_facecache.h" #include "core/fxge/cfx_fontcache.h" diff --git a/core/fxge/ge/cfx_fontcache.cpp b/core/fxge/ge/cfx_fontcache.cpp index 2a4d243719..58cee06d42 100644 --- a/core/fxge/ge/cfx_fontcache.cpp +++ b/core/fxge/ge/cfx_fontcache.cpp @@ -6,6 +6,9 @@ #include "core/fxge/cfx_fontcache.h" +#include <memory> +#include <utility> + #include "core/fxge/cfx_facecache.h" #include "core/fxge/fx_font.h" #include "core/fxge/fx_freetype.h" diff --git a/core/fxge/ge/cfx_fontmgr.cpp b/core/fxge/ge/cfx_fontmgr.cpp index 1d1ebca4a4..64f647e3f6 100644 --- a/core/fxge/ge/cfx_fontmgr.cpp +++ b/core/fxge/ge/cfx_fontmgr.cpp @@ -6,6 +6,9 @@ #include "core/fxge/cfx_fontmgr.h" +#include <memory> +#include <utility> + #include "core/fxge/cfx_fontmapper.h" #include "core/fxge/cfx_substfont.h" #include "core/fxge/fontdata/chromefontdata/chromefontdata.h" diff --git a/core/fxge/ge/cfx_renderdevice.cpp b/core/fxge/ge/cfx_renderdevice.cpp index a4ce6b7d5e..10135273c6 100644 --- a/core/fxge/ge/cfx_renderdevice.cpp +++ b/core/fxge/ge/cfx_renderdevice.cpp @@ -6,6 +6,11 @@ #include "core/fxge/cfx_renderdevice.h" +#include <algorithm> +#include <memory> +#include <utility> +#include <vector> + #include "core/fxcrt/fx_safe_types.h" #include "core/fxge/cfx_facecache.h" #include "core/fxge/cfx_fxgedevice.h" diff --git a/core/fxge/ge/fx_ge_fontmap.cpp b/core/fxge/ge/fx_ge_fontmap.cpp index f8c36d8f07..7ac4fada5c 100644 --- a/core/fxge/ge/fx_ge_fontmap.cpp +++ b/core/fxge/ge/fx_ge_fontmap.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <memory> + #include "core/fxge/cfx_fontmapper.h" #include "core/fxge/ifx_systemfontinfo.h" diff --git a/core/fxge/ifx_systemfontinfo.h b/core/fxge/ifx_systemfontinfo.h index 640a11a57b..1ab0ab677c 100644 --- a/core/fxge/ifx_systemfontinfo.h +++ b/core/fxge/ifx_systemfontinfo.h @@ -7,6 +7,8 @@ #ifndef CORE_FXGE_IFX_SYSTEMFONTINFO_H_ #define CORE_FXGE_IFX_SYSTEMFONTINFO_H_ +#include <memory> + #include "core/fxge/cfx_fontmapper.h" #include "core/fxge/fx_font.h" diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp index d525c470af..973c4f2b34 100644 --- a/core/fxge/skia/fx_skia_device.cpp +++ b/core/fxge/skia/fx_skia_device.cpp @@ -3,6 +3,7 @@ // found in the LICENSE file. #include <algorithm> +#include <utility> #include <vector> #include "core/fxcodec/fx_codec.h" diff --git a/core/fxge/skia/fx_skia_device.h b/core/fxge/skia/fx_skia_device.h index bbbbdaa2dd..f2576a888d 100644 --- a/core/fxge/skia/fx_skia_device.h +++ b/core/fxge/skia/fx_skia_device.h @@ -7,6 +7,9 @@ #if defined _SKIA_SUPPORT_ || defined _SKIA_SUPPORT_PATHS_ +#include <memory> +#include <vector> + #include "core/fxge/cfx_pathdata.h" #include "core/fxge/ifx_renderdevicedriver.h" |