diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-01-09 10:46:50 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-01-09 10:46:50 -0800 |
| commit | b9e0190938f62bf21df078e47190a62ba33ddab2 (patch) | |
| tree | 474749da63ac6890c008f9535b335bebee1d7cc8 /core/include/fxcrt/fx_arb.h | |
| parent | b07772a31f5dff723af620bc57c71daa246995c0 (diff) | |
| download | pdfium-b9e0190938f62bf21df078e47190a62ba33ddab2.tar.xz | |
Fix -Wnon-virtual-dtor compiler warnings.
This is done by explicitly adding a virtual dtor to interface classes,
since the cost is small given that there are already virtual functions.
The exceptions are for classes that have a Release() or Delete() method,
in which case it is non-virtual and protected to indicate that the virtual
class is never the deletion point.
BUG=
R=brucedawson@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/810883005
Diffstat (limited to 'core/include/fxcrt/fx_arb.h')
| -rw-r--r-- | core/include/fxcrt/fx_arb.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/core/include/fxcrt/fx_arb.h b/core/include/fxcrt/fx_arb.h index 4950f81716..a7b25c1877 100644 --- a/core/include/fxcrt/fx_arb.h +++ b/core/include/fxcrt/fx_arb.h @@ -16,5 +16,8 @@ public: virtual FX_BOOL EndChar() = 0; virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) = 0; virtual void Reset() = 0; + +protected: + ~IFX_BidiChar() { } }; #endif |