diff options
| author | Lei Zhang <thestig@chromium.org> | 2015-10-19 12:08:54 -0700 |
|---|---|---|
| committer | Lei Zhang <thestig@chromium.org> | 2015-10-19 12:08:54 -0700 |
| commit | 29cd8b9631408c0360c744e23a2733d24c9224ec (patch) | |
| tree | 6ea0cc3a574993b4a2f6f26968e18a19ca1f91f6 /core/include/fxcrt/fx_basic.h | |
| parent | 184e4a189d1391bff014aa6ecc0f9b0d83081826 (diff) | |
| download | pdfium-29cd8b9631408c0360c744e23a2733d24c9224ec.tar.xz | |
Merge to XFA: Remove some checks for object creation failures. They cannot fail.
Also reduce nesting in if statements, remove CFX_SmartPointer, and
use more unique_ptrs.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393303004 .
(cherry picked from commit 6101a5f98b27888f1736ae74982ed4d409d83be0)
Review URL: https://codereview.chromium.org/1413223002 .
Diffstat (limited to 'core/include/fxcrt/fx_basic.h')
| -rw-r--r-- | core/include/fxcrt/fx_basic.h | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h index b85d737327..44e6a46ae7 100644 --- a/core/include/fxcrt/fx_basic.h +++ b/core/include/fxcrt/fx_basic.h @@ -1084,20 +1084,6 @@ struct ReleaseDeleter { inline void operator()(T* ptr) const { ptr->Release(); } }; -// TODO(thestig) Remove in favor of nonstd::unique_ptr. -template <class T> -class CFX_SmartPointer { - public: - CFX_SmartPointer(T* pObj) : m_pObj(pObj) {} - ~CFX_SmartPointer() { m_pObj->Release(); } - T* Get(void) { return m_pObj; } - T& operator*(void) { return *m_pObj; } - T* operator->(void) { return m_pObj; } - - protected: - T* m_pObj; -}; - #define FX_DATALIST_LENGTH 1024 template <size_t unit> class CFX_SortListArray { |