diff options
| author | Chris Palmer <palmer@google.com> | 2014-07-08 13:27:00 -0700 |
|---|---|---|
| committer | Chris Palmer <palmer@google.com> | 2014-07-08 13:27:00 -0700 |
| commit | 30f2ff16bf30ccaa66bb7e144873fc29b4bcbdc2 (patch) | |
| tree | f19a9a9996bf7150cbce303a241e3366ffd01a86 /core/include/fxcrt/fx_string.h | |
| parent | d7db790d5d92925070c7da7b6f63b5a642dd90fc (diff) | |
| download | pdfium-30f2ff16bf30ccaa66bb7e144873fc29b4bcbdc2.tar.xz | |
Fix integer overflow in fx_basic_[bw]string.cpp.
BUG=382601
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/336003004
Diffstat (limited to 'core/include/fxcrt/fx_string.h')
| -rw-r--r-- | core/include/fxcrt/fx_string.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/include/fxcrt/fx_string.h b/core/include/fxcrt/fx_string.h index 08fb83cfd7..7e02101def 100644 --- a/core/include/fxcrt/fx_string.h +++ b/core/include/fxcrt/fx_string.h @@ -340,7 +340,7 @@ public: protected: struct CFX_StringData* m_pData; - void AllocCopy(CFX_ByteString& dest, FX_STRSIZE nCopyLen, FX_STRSIZE nCopyIndex, FX_STRSIZE nExtraLen) const; + void AllocCopy(CFX_ByteString& dest, FX_STRSIZE nCopyLen, FX_STRSIZE nCopyIndex) const; void AssignCopy(FX_STRSIZE nSrcLen, FX_LPCSTR lpszSrcData); void ConcatCopy(FX_STRSIZE nSrc1Len, FX_LPCSTR lpszSrc1Data, FX_STRSIZE nSrc2Len, FX_LPCSTR lpszSrc2Data); void ConcatInPlace(FX_STRSIZE nSrcLen, FX_LPCSTR lpszSrcData); @@ -756,7 +756,7 @@ protected: void ConcatInPlace(FX_STRSIZE nSrcLen, FX_LPCWSTR lpszSrcData); void ConcatCopy(FX_STRSIZE nSrc1Len, FX_LPCWSTR lpszSrc1Data, FX_STRSIZE nSrc2Len, FX_LPCWSTR lpszSrc2Data); void AssignCopy(FX_STRSIZE nSrcLen, FX_LPCWSTR lpszSrcData); - void AllocCopy(CFX_WideString& dest, FX_STRSIZE nCopyLen, FX_STRSIZE nCopyIndex, FX_STRSIZE nExtraLen) const; + void AllocCopy(CFX_WideString& dest, FX_STRSIZE nCopyLen, FX_STRSIZE nCopyIndex) const; }; inline CFX_WideStringC::CFX_WideStringC(const CFX_WideString& src) { |