diff options
| author | Lei Zhang <thestig@chromium.org> | 2015-06-19 14:58:28 -0700 |
|---|---|---|
| committer | Lei Zhang <thestig@chromium.org> | 2015-06-19 14:58:28 -0700 |
| commit | 568aff520b4ca33d851317a4ea88807b4fd2da40 (patch) | |
| tree | 02c6409057908381d36efcd556dd8082044d5509 /core/include/fxcrt | |
| parent | c49828916f5b0766f8d6f0fd5bf0a6cc5bd3c1ec (diff) | |
| download | pdfium-568aff520b4ca33d851317a4ea88807b4fd2da40.tar.xz | |
Fix -Wnon-virtual-dtor warnings on the XFA branch.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1183483003.
Diffstat (limited to 'core/include/fxcrt')
| -rw-r--r-- | core/include/fxcrt/fx_arb.h | 1 | ||||
| -rw-r--r-- | core/include/fxcrt/fx_basic.h | 1 | ||||
| -rw-r--r-- | core/include/fxcrt/fx_stream.h | 12 |
3 files changed, 8 insertions, 6 deletions
diff --git a/core/include/fxcrt/fx_arb.h b/core/include/fxcrt/fx_arb.h index 5d3b0eb7da..3886ac3aae 100644 --- a/core/include/fxcrt/fx_arb.h +++ b/core/include/fxcrt/fx_arb.h @@ -49,6 +49,7 @@ class IFX_ArabicChar { public: static IFX_ArabicChar* Create(); + virtual ~IFX_ArabicChar() {} virtual void Release() = 0; virtual FX_BOOL IsArabicChar(FX_WCHAR wch) const = 0; virtual FX_BOOL IsArabicFormChar(FX_WCHAR wch) const = 0; diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h index cbd9cd85a8..b5a110b86f 100644 --- a/core/include/fxcrt/fx_basic.h +++ b/core/include/fxcrt/fx_basic.h @@ -1576,6 +1576,7 @@ typedef enum { class IFX_Unknown { public: + virtual ~IFX_Unknown() {} virtual FX_DWORD Release() = 0; virtual FX_DWORD AddRef() = 0; }; diff --git a/core/include/fxcrt/fx_stream.h b/core/include/fxcrt/fx_stream.h index c5d7b40df1..836cd272ae 100644 --- a/core/include/fxcrt/fx_stream.h +++ b/core/include/fxcrt/fx_stream.h @@ -67,9 +67,8 @@ FX_BOOL FX_File_Move(const CFX_WideStringC& fileNameSrc, const CFX_WideStringC& class IFX_StreamWrite { public: - virtual ~IFX_StreamWrite() { } + virtual ~IFX_StreamWrite() {} virtual void Release() = 0; - virtual FX_BOOL WriteBlock(const void* pData, size_t size) = 0; }; class IFX_FileWrite : public IFX_StreamWrite @@ -167,10 +166,11 @@ IFX_FileStream* FX_CreateFileStream(const FX_WCHAR* filename, FX_DWORD dwModes) class IFX_FileAccess { public: - virtual void Release() = 0; - virtual IFX_FileAccess* Retain() = 0; - virtual void GetPath(CFX_WideString& wsPath) = 0; - virtual IFX_FileStream* CreateFileStream(FX_DWORD dwModes) = 0; + virtual ~IFX_FileAccess() {} + virtual void Release() = 0; + virtual IFX_FileAccess* Retain() = 0; + virtual void GetPath(CFX_WideString& wsPath) = 0; + virtual IFX_FileStream* CreateFileStream(FX_DWORD dwModes) = 0; }; IFX_FileAccess* FX_CreateDefaultFileAccess(const CFX_WideStringC& wsPath); class IFX_MemoryStream : public IFX_FileStream |