FPDF_Creator can only create file through embedder-supplied callback.

Hence, some of the routines taking filename strings are unused. This,
in turn allows us to get rid of some other fopen-ishy looking things
inside the library.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1264423003 .

3 files changed, 1 insertions, 16 deletions

diff --git a/core/include/fpdfapi/fpdf_serial.h b/core/include/fpdfapi/fpdf_serial.h
index 7197e0d7b0..4a325341cb 100644
--- a/core/include/fpdfapi/fpdf_serial.h
+++ b/core/include/fpdfapi/fpdf_serial.h
@@ -17,22 +17,15 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj);
 #define FPDFCREATE_NO_ORIGINAL 2
 #define FPDFCREATE_PROGRESSIVE 4
 #define FPDFCREATE_OBJECTSTREAM 8
+
 class CPDF_Creator {
  public:
   CPDF_Creator(CPDF_Document* pDoc);
-
   ~CPDF_Creator();
 
   void RemoveSecurity();
-
-  FX_BOOL Create(const FX_WCHAR* filename, FX_DWORD flags = 0);
-
-  FX_BOOL Create(const FX_CHAR* filename, FX_DWORD flags = 0);
-
   FX_BOOL Create(IFX_StreamWrite* pFile, FX_DWORD flags = 0);
-
   int32_t Continue(IFX_Pause* pPause = NULL);
-
   FX_BOOL SetFileVersion(int32_t fileVersion = 17);
 
  protected:
diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h
index 7181b19942..73b99be549 100644
--- a/core/include/fxcrt/fx_basic.h
+++ b/core/include/fxcrt/fx_basic.h
@@ -164,18 +164,12 @@ class CFX_FileBufferArchive : public IFX_BufferArchive {
   ~CFX_FileBufferArchive() override;
 
   void Clear() override;
-
   FX_BOOL AttachFile(IFX_StreamWrite* pFile, FX_BOOL bTakeover = FALSE);
 
-  FX_BOOL AttachFile(const FX_WCHAR* filename);
-
-  FX_BOOL AttachFile(const FX_CHAR* filename);
-
  private:
   FX_BOOL DoWork(const void* pBuf, size_t size) override;
 
   IFX_StreamWrite* m_pFile;
-
   FX_BOOL m_bTakeover;
 };
 
diff --git a/core/include/fxcrt/fx_stream.h b/core/include/fxcrt/fx_stream.h
index 2f3ebdcfce..73ec7e05b2 100644
--- a/core/include/fxcrt/fx_stream.h
+++ b/core/include/fxcrt/fx_stream.h
@@ -78,8 +78,6 @@ class IFX_FileWrite : public IFX_StreamWrite {
     return WriteBlock(pData, GetSize(), size);
   }
 };
-IFX_FileWrite* FX_CreateFileWrite(const FX_CHAR* filename);
-IFX_FileWrite* FX_CreateFileWrite(const FX_WCHAR* filename);
 class IFX_StreamRead {
  public:
   virtual ~IFX_StreamRead() {}