diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:28:50 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:28:50 -0700 |
| commit | 71c15a5e6652952a94ba3a3ef7ac0392e3a06962 (patch) | |
| tree | c6983e985c49e4f30906082b73045db14d8cb481 /core/src/fpdfapi/fpdf_font | |
| parent | a2b3ae23556fb2f1adbc008574f33bf365476af9 (diff) | |
| download | pdfium-71c15a5e6652952a94ba3a3ef7ac0392e3a06962.tar.xz | |
Extern in .cpp files is a code smell.
Part 1. Move to headers so compiler can type check against
the definitions.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1299963002 .
Diffstat (limited to 'core/src/fpdfapi/fpdf_font')
| -rw-r--r-- | core/src/fpdfapi/fpdf_font/font_int.h | 3 | ||||
| -rw-r--r-- | core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp | 5 |
2 files changed, 3 insertions, 5 deletions
diff --git a/core/src/fpdfapi/fpdf_font/font_int.h b/core/src/fpdfapi/fpdf_font/font_int.h index 59acfcbd35..79c25219a0 100644 --- a/core/src/fpdfapi/fpdf_font/font_int.h +++ b/core/src/fpdfapi/fpdf_font/font_int.h @@ -19,6 +19,9 @@ class CPDF_Stream; typedef void* FXFT_Library; +short TT2PDF(int m, FXFT_Face face); +FX_BOOL FT_UseTTCharmap(FXFT_Face face, int platform_id, int encoding_id); + class CPDF_CMapManager { public: CPDF_CMapManager(); diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp index 4814e93e7b..acbb567834 100644 --- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp +++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp @@ -12,11 +12,6 @@ #include "../fpdf_cmaps/cmap_int.h" #include "font_int.h" -extern short TT2PDF(int m, FXFT_Face face); -extern FX_BOOL FT_UseTTCharmap(FXFT_Face face, - int platform_id, - int encoding_id); - CPDF_CMapManager::CPDF_CMapManager() { m_bPrompted = FALSE; FXSYS_memset(m_CID2UnicodeMaps, 0, sizeof m_CID2UnicodeMaps); |