Add test for CPDF_StreamParser::ReadHexString.chromium/2555chromium/2554chromium/2553

This CL adds a unit test for the ReadHexString method.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1408213008 .

1 files changed, 48 insertions, 0 deletions

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
new file mode 100644
index 0000000000..3fc012f29c
--- /dev/null
+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp
@@ -0,0 +1,48 @@
+// Copyright 2015 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "pageint.h"
+
+TEST(fpdf_page_parser_old, ReadHexString) {
+  {
+    // Position out of bounds.
+    uint8_t data[] = "12ab>";
+    CPDF_StreamParser parser(data, 5);
+    parser.SetPos(6);
+    EXPECT_EQ("", parser.ReadHexString());
+  }
+
+  {
+    // Regular conversion.
+    uint8_t data[] = "1A2b>abcd";
+    CPDF_StreamParser parser(data, 5);
+    EXPECT_EQ("\x1a\x2b", parser.ReadHexString());
+    EXPECT_EQ(5, parser.GetPos());
+  }
+
+  {
+    // Missing ending >
+    uint8_t data[] = "1A2b";
+    CPDF_StreamParser parser(data, 5);
+    EXPECT_EQ("\x1a\x2b", parser.ReadHexString());
+    EXPECT_EQ(5, parser.GetPos());
+  }
+
+  {
+    // Uneven number of bytes.
+    uint8_t data[] = "1A2>asdf";
+    CPDF_StreamParser parser(data, 5);
+    EXPECT_EQ("\x1a\x20", parser.ReadHexString());
+    EXPECT_EQ(4, parser.GetPos());
+  }
+
+  {
+    uint8_t data[] = ">";
+    CPDF_StreamParser parser(data, 5);
+    EXPECT_EQ("", parser.ReadHexString());
+    EXPECT_EQ(1, parser.GetPos());
+  }
+}