summaryrefslogtreecommitdiff
path: root/core/src/fpdfapi/fpdf_page
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2015-10-27 12:08:20 -0400
committerDan Sinclair <dsinclair@chromium.org>2015-10-27 12:08:20 -0400
commit4ef782ab57979add3e3910d6bcfde6ef59f65724 (patch)
tree7621042ce315f4ec8398675b868379d802a5ea90 /core/src/fpdfapi/fpdf_page
parent24b2eab6351920dd60210b6dcd350c9921e7b3b5 (diff)
downloadpdfium-4ef782ab57979add3e3910d6bcfde6ef59f65724.tar.xz
Type check the m_pShadingObj before assuming it's a stream.
The m_pShadingObj can be a stream or a dictionary depending on how it's used. This CL adds some simple type checking to make sure that the type of the object matches what we expect. BUG=chromium:547706 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1421973004 .
Diffstat (limited to 'core/src/fpdfapi/fpdf_page')
-rw-r--r--core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp
index 7b04d8cd33..ded6c878ea 100644
--- a/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp
+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp
@@ -140,6 +140,11 @@ FX_BOOL CPDF_ShadingPattern::Load() {
m_pCountedCS = pDocPageData->FindColorSpacePtr(m_pCS->GetArray());
}
m_ShadingType = pShadingDict->GetInteger(FX_BSTRC("ShadingType"));
+
+ // We expect to have a stream if our shading type is a mesh.
+ if (m_ShadingType >= 4 && !ToStream(m_pShadingObj))
+ return FALSE;
+
return TRUE;
}
FX_BOOL CPDF_ShadingPattern::Reload() {