diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2015-10-20 14:57:56 -0400 |
---|---|---|
committer | Dan Sinclair <dsinclair@chromium.org> | 2015-10-20 14:57:56 -0400 |
commit | 39869b641511c882d78e17548293cdb458c36f38 (patch) | |
tree | 6e7fee229f9c8a5d628c2dfe81b3e9848a9670d2 /core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp | |
parent | 19169dae5bf92813b7419793f61dfca8b4fb9124 (diff) | |
download | pdfium-39869b641511c882d78e17548293cdb458c36f38.tar.xz |
Revert "Revert "Add type cast definitions for CPDF_Dictionary.""
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c.
Add type cast definitions for CPDF_Dictionary.
This CL adds ToCPDFDictionary type definitions and updates one file to use
instead of straight casts. I had to fix two places where we'd casted off the
constness of the original pointer.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1420583003 .
Diffstat (limited to 'core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp')
-rw-r--r-- | core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp index 2dff766187..29c1a007cf 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp @@ -143,18 +143,15 @@ CPDF_Dictionary* CPDF_Document::GetPage(int iPage) { return nullptr; if (m_bLinearized && (iPage == (int)m_dwFirstPageNo)) { - CPDF_Object* pObj = GetIndirectObject(m_dwFirstPageObjNum); - if (pObj && pObj->GetType() == PDFOBJ_DICTIONARY) { - return static_cast<CPDF_Dictionary*>(pObj); - } + if (CPDF_Dictionary* pDict = + ToDictionary(GetIndirectObject(m_dwFirstPageObjNum))) + return pDict; } int objnum = m_PageList.GetAt(iPage); if (objnum) { - CPDF_Object* pObj = GetIndirectObject(objnum); - if (pObj && pObj->GetType() == PDFOBJ_DICTIONARY) { - return static_cast<CPDF_Dictionary*>(pObj); - } + if (CPDF_Dictionary* pDict = ToDictionary(GetIndirectObject(objnum))) + return pDict; } CPDF_Dictionary* pRoot = GetRoot(); |