diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2015-10-28 13:32:35 -0400 |
|---|---|---|
| committer | Dan Sinclair <dsinclair@chromium.org> | 2015-10-28 13:32:35 -0400 |
| commit | dd4cd523ef4546b43d68e8ca6ec0a97fbe8954e9 (patch) | |
| tree | dc4465dea283ad6b3b48625ff348f7ccabc05e31 /core/src/fpdfapi | |
| parent | b9d06fb2186d7002d6231d1805bcf97fc60144c5 (diff) | |
| download | pdfium-dd4cd523ef4546b43d68e8ca6ec0a97fbe8954e9.tar.xz | |
Check if document was opened during testing.
When we call OpenDocument we fail to check if the document was actually opened.
Currently we return true in all cases (assuming we read the file). This CL
updates the code to check if the document was opened and return false if not.
I've updated several tests to check for FALSE instead of TRUE. I verified the
documents in fact don't open with my local (non-PDFium) PDF reader.
BUG=pdfium:223
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417893007 .
Diffstat (limited to 'core/src/fpdfapi')
| -rw-r--r-- | core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp index b6cfc4e89f..ed2863bcf3 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp @@ -9,7 +9,7 @@ class FPDFParserEmbeddertest : public EmbedderTest {}; TEST_F(FPDFParserEmbeddertest, LoadError_454695) { // Test trailer dictionary with $$ze instead of Size. - EXPECT_TRUE(OpenDocument("testing/resources/bug_454695.pdf")); + EXPECT_FALSE(OpenDocument("testing/resources/bug_454695.pdf")); } TEST_F(FPDFParserEmbeddertest, Bug_481363) { |