diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-04-20 12:29:12 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-04-20 12:29:12 -0700 |
| commit | bc580c69403169afa656aabb06a56b26d3b729cf (patch) | |
| tree | 3f0efd776e2067f4f4329db4f79a8467a766575b /core/src/fpdfapi | |
| parent | 0fff5ef23382f8c13d079dae41b1664999d9c2a7 (diff) | |
| download | pdfium-bc580c69403169afa656aabb06a56b26d3b729cf.tar.xz | |
Remove Release() from CPDF_PageObject
BUG=pdfium:140
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1093213002
Diffstat (limited to 'core/src/fpdfapi')
| -rw-r--r-- | core/src/fpdfapi/fpdf_page/fpdf_page.cpp | 19 | ||||
| -rw-r--r-- | core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp | 3 |
2 files changed, 6 insertions, 16 deletions
diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp index 998bc274b0..4ec753d751 100644 --- a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp +++ b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp @@ -7,10 +7,6 @@ #include "../../../include/fpdfapi/fpdf_page.h" #include "../../../include/fpdfapi/fpdf_module.h" #include "pageint.h" -void CPDF_PageObject::Release() -{ - delete this; -} CPDF_PageObject* CPDF_PageObject::Create(int type) { switch (type) { @@ -27,6 +23,9 @@ CPDF_PageObject* CPDF_PageObject::Create(int type) } return NULL; } +CPDF_PageObject::~CPDF_PageObject() +{ +} CPDF_PageObject* CPDF_PageObject::Clone() const { CPDF_PageObject* pObj = Create(m_Type); @@ -689,11 +688,7 @@ CPDF_PageObjects::~CPDF_PageObjects() } FX_POSITION pos = m_ObjectList.GetHeadPosition(); while (pos) { - CPDF_PageObject* pPageObj = (CPDF_PageObject*)m_ObjectList.GetNext(pos); - if (!pPageObj) { - continue; - } - pPageObj->Release(); + delete (CPDF_PageObject*)m_ObjectList.GetNext(pos); } } void CPDF_PageObjects::ContinueParse(IFX_Pause* pPause) @@ -808,11 +803,7 @@ void CPDF_PageObjects::ClearCacheObjects() if (m_bReleaseMembers) { FX_POSITION pos = m_ObjectList.GetHeadPosition(); while (pos) { - CPDF_PageObject* pPageObj = (CPDF_PageObject*)m_ObjectList.GetNext(pos); - if (!pPageObj) { - continue; - } - pPageObj->Release(); + delete (CPDF_PageObject*)m_ObjectList.GetNext(pos); } } m_ObjectList.RemoveAll(); diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp index 40ec13ea6e..f79fcda0a0 100644 --- a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp +++ b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp @@ -192,8 +192,7 @@ void CPDF_ClipPath::AppendTexts(CPDF_TextObject** pTexts, int count) CPDF_ClipPathData* pData = GetModify(); if (pData->m_TextCount + count > FPDF_CLIPPATH_MAX_TEXTS) { for (int i = 0; i < count; i ++) { - if (pTexts[i]) - pTexts[i]->Release(); + delete pTexts[i]; } return; } |