diff options
| author | Nico Weber <thakis@chromium.org> | 2014-07-18 09:14:35 -0700 |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2014-07-18 09:14:35 -0700 |
| commit | 5eb9f7b4542cca34d4af96ea43be362446a4794f (patch) | |
| tree | b0a0fdd6b1c525bf3633d6de2b79b70058e2cc7d /core/src/fpdfapi | |
| parent | a9c29e006f74fefd96d5c3eab9d8233b321b296a (diff) | |
| download | pdfium-5eb9f7b4542cca34d4af96ea43be362446a4794f.tar.xz | |
pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.
Calling `delete` on an object of a type that has virtual functions but
not a virtual destructor is questionable: Since the object has virtual functions,
it likely has subclasses, so if it's deleted through the base pointer and the
destructor isn't virtual, the subclass destructor won't be called.
In most cases, the classes getting deleted can just be marked final to tell
the compiler that it can't possibly have subclasses (this also enables the
compiler to generate better code).
Two classes didn't have any sub- or superclasses but virtual functions -
this doesn't make sense, so make all methods of these classes non-virtual.
(Also delete an unused function on one of the two classes.)
In one case, a class actually did have a subclass that needs to be deleted
virtually, so mark one destructor as virtual.
BUG=none
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/370853002
Diffstat (limited to 'core/src/fpdfapi')
| -rw-r--r-- | core/src/fpdfapi/fpdf_font/ttgsubtable.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/src/fpdfapi/fpdf_font/ttgsubtable.h b/core/src/fpdfapi/fpdf_font/ttgsubtable.h index bf9c7a4c42..26f67fbd18 100644 --- a/core/src/fpdfapi/fpdf_font/ttgsubtable.h +++ b/core/src/fpdfapi/fpdf_font/ttgsubtable.h @@ -406,7 +406,7 @@ private: struct TFeatureList FeatureList; struct TLookupList LookupList; }; -class CFX_GSUBTable : public IFX_GSUBTable, public CFX_Object +class CFX_GSUBTable FX_FINAL : public IFX_GSUBTable, public CFX_Object { public: virtual void Release() |