Merge to XFA: Use std::map as CPDF_Dictionary's underlying store.

Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.

Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.

TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1541703003 .

(cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f)

Review URL: https://codereview.chromium.org/1576033002 .

1 files changed, 0 insertions, 31 deletions

diff --git a/core/src/fpdfdoc/doc_action.cpp b/core/src/fpdfdoc/doc_action.cpp
index e68a8c8a06..28d17cd673 100644
--- a/core/src/fpdfdoc/doc_action.cpp
+++ b/core/src/fpdfdoc/doc_action.cpp
@@ -257,37 +257,6 @@ CPDF_Action CPDF_AAction::GetAction(AActionType eType) const {
   }
   return CPDF_Action(m_pDict->GetDict(g_sAATypes[(int)eType]));
 }
-FX_POSITION CPDF_AAction::GetStartPos() const {
-  if (!m_pDict) {
-    return NULL;
-  }
-  return m_pDict->GetStartPos();
-}
-CPDF_Action CPDF_AAction::GetNextAction(FX_POSITION& pos,
-                                        AActionType& eType) const {
-  if (!m_pDict) {
-    return CPDF_Action();
-  }
-  CFX_ByteString csKey;
-  CPDF_Object* pObj = m_pDict->GetNextElement(pos, csKey);
-  if (!pObj) {
-    return CPDF_Action();
-  }
-  CPDF_Object* pDirect = pObj->GetDirect();
-  CPDF_Dictionary* pDict = ToDictionary(pDirect);
-  if (!pDict)
-    return CPDF_Action();
-
-  int i = 0;
-  while (g_sAATypes[i][0] != '\0') {
-    if (csKey == g_sAATypes[i]) {
-      break;
-    }
-    i++;
-  }
-  eType = (AActionType)i;
-  return CPDF_Action(pDict);
-}
 
 CPDF_DocJSActions::CPDF_DocJSActions(CPDF_Document* pDoc) : m_pDocument(pDoc) {}