diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-03-05 16:30:09 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-03-05 16:30:09 -0800 |
| commit | 624b6c1e0fc6a5b0467061ef37b6db6856681afb (patch) | |
| tree | 8b1083b0b3f167da7fa7747ab530a9b37dab44b7 /core/src/fpdfdoc/doc_bookmark.cpp | |
| parent | 61c25eebf5a0fcf44dd1a434c88f502a34073eac (diff) | |
| download | pdfium-624b6c1e0fc6a5b0467061ef37b6db6856681afb.tar.xz | |
Make conversion between CPDF_Action and its dictionary explicit.
Precursor to taking a second shot at cleaning up the FPDF_*
APIs. A FPDF_Action is a CPDF_Dictionary, and a CPDF_Action
is a structure holding a FPDF_Action. This goes against the
convention that FPDF_ types get cast to CPDF_* types, so we
want to make it clear where objects are getting constructed,
etc.
Also tidy fpdf_actionhandler.cpp because it bugs me.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/984773002
Diffstat (limited to 'core/src/fpdfdoc/doc_bookmark.cpp')
| -rw-r--r-- | core/src/fpdfdoc/doc_bookmark.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/src/fpdfdoc/doc_bookmark.cpp b/core/src/fpdfdoc/doc_bookmark.cpp index e7b383eced..a3a194337e 100644 --- a/core/src/fpdfdoc/doc_bookmark.cpp +++ b/core/src/fpdfdoc/doc_bookmark.cpp @@ -86,7 +86,7 @@ CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const CPDF_Action CPDF_Bookmark::GetAction() const { if (!m_pDict) { - return NULL; + return CPDF_Action(); } - return m_pDict->GetDict("A"); + return CPDF_Action(m_pDict->GetDict("A")); } |