diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-04-27 15:10:00 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-04-27 15:10:00 -0700 |
| commit | 00948f58ae4ba3713e2e25080c9e229ecbe929eb (patch) | |
| tree | 6f62b5280dd1755d8b52c775484b20cbe22fd7d5 /core/src/fpdfdoc/doc_bookmark.cpp | |
| parent | ee7412f5aef353e5c6f1a64d0e1708ed926869d9 (diff) | |
| download | pdfium-00948f58ae4ba3713e2e25080c9e229ecbe929eb.tar.xz | |
Revert "Make CFX_WideString::LockBuffer() completely unused."
This reverts commit ee7412f5aef353e5c6f1a64d0e1708ed926869d9.
Reason for revert: VS compile broke.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1106333003
Diffstat (limited to 'core/src/fpdfdoc/doc_bookmark.cpp')
| -rw-r--r-- | core/src/fpdfdoc/doc_bookmark.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/core/src/fpdfdoc/doc_bookmark.cpp b/core/src/fpdfdoc/doc_bookmark.cpp index 88dcf21be1..9814de61bf 100644 --- a/core/src/fpdfdoc/doc_bookmark.cpp +++ b/core/src/fpdfdoc/doc_bookmark.cpp @@ -55,13 +55,15 @@ CFX_WideString CPDF_Bookmark::GetTitle() const return CFX_WideString(); } CFX_WideString title = pString->GetUnicodeText(); + FX_LPWSTR buf = title.LockBuffer(); int len = title.GetLength(); - FX_WCHAR buf[len]; for (int i = 0; i < len; i++) { - FX_WCHAR w = title[i]; - buf[i] = w > 0x20 ? w : 0x20; + if (buf[i] < 0x20) { + buf[i] = 0x20; + } } - return CFX_WideString(buf, len); + title.ReleaseBuffer(len); + return title; } CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const { |