diff options
author | Wei Li <weili@chromium.org> | 2016-03-01 16:29:41 -0800 |
---|---|---|
committer | Wei Li <weili@chromium.org> | 2016-03-01 16:29:41 -0800 |
commit | 0fc6b25e738c311fd66aa9da8c56de50af5644d5 (patch) | |
tree | e148556274b450ae125e2821debebb472f1ba8ee /core/src/fpdfdoc/doc_formcontrol.cpp | |
parent | 738b08ce6b9f80d93b815411b47c2b11c2f090f6 (diff) | |
download | pdfium-0fc6b25e738c311fd66aa9da8c56de50af5644d5.tar.xz |
Remove implicit conversions and some cleanup
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1751753002 .
Diffstat (limited to 'core/src/fpdfdoc/doc_formcontrol.cpp')
-rw-r--r-- | core/src/fpdfdoc/doc_formcontrol.cpp | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/core/src/fpdfdoc/doc_formcontrol.cpp b/core/src/fpdfdoc/doc_formcontrol.cpp index 169e9d73b7..4cfd4527e2 100644 --- a/core/src/fpdfdoc/doc_formcontrol.cpp +++ b/core/src/fpdfdoc/doc_formcontrol.cpp @@ -246,27 +246,27 @@ CPDF_Action CPDF_FormControl::GetAction() { } return CPDF_Action(pObj->GetDict()); } + CPDF_AAction CPDF_FormControl::GetAdditionalAction() { - if (!m_pWidgetDict) { - return nullptr; - } - if (m_pWidgetDict->KeyExist("AA")) { - return m_pWidgetDict->GetDictBy("AA"); - } + if (!m_pWidgetDict) + return CPDF_AAction(); + + if (m_pWidgetDict->KeyExist("AA")) + return CPDF_AAction(m_pWidgetDict->GetDictBy("AA")); return m_pField->GetAdditionalAction(); } + CPDF_DefaultAppearance CPDF_FormControl::GetDefaultAppearance() { - if (!m_pWidgetDict) { - return CFX_ByteString(); - } - if (m_pWidgetDict->KeyExist("DA")) { - return m_pWidgetDict->GetStringBy("DA"); - } + if (!m_pWidgetDict) + return CPDF_DefaultAppearance(); + + if (m_pWidgetDict->KeyExist("DA")) + return CPDF_DefaultAppearance(m_pWidgetDict->GetStringBy("DA")); + CPDF_Object* pObj = FPDF_GetFieldAttr(m_pField->m_pDict, "DA"); - if (!pObj) { - return m_pField->m_pForm->GetDefaultAppearance(); - } - return pObj->GetString(); + if (pObj) + return CPDF_DefaultAppearance(pObj->GetString()); + return m_pField->m_pForm->GetDefaultAppearance(); } CPDF_Font* CPDF_FormControl::GetDefaultControlFont() { @@ -421,7 +421,7 @@ CPDF_Stream* CPDF_ApSettings::GetIcon(const CFX_ByteStringC& csEntry) const { } CPDF_IconFit CPDF_ApSettings::GetIconFit() const { - return m_pDict ? m_pDict->GetDictBy("IF") : nullptr; + return CPDF_IconFit(m_pDict ? m_pDict->GetDictBy("IF") : nullptr); } int CPDF_ApSettings::GetTextPosition() const { |