diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2016-03-09 09:59:23 -0500 |
|---|---|---|
| committer | Dan Sinclair <dsinclair@chromium.org> | 2016-03-09 09:59:23 -0500 |
| commit | 3ebd121d45ceb08918a3dcb5b3b7ac29448c862f (patch) | |
| tree | 361d5fa0f9be7484cce4aace1b9cc18545046611 /core/src/fpdfdoc | |
| parent | 317758574e173367b41928a1575d70600c6b6ea8 (diff) | |
| download | pdfium-3ebd121d45ceb08918a3dcb5b3b7ac29448c862f.tar.xz | |
Review and cleanup lint warnings.
This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773733002 .
Diffstat (limited to 'core/src/fpdfdoc')
| -rw-r--r-- | core/src/fpdfdoc/doc_action.cpp | 2 | ||||
| -rw-r--r-- | core/src/fpdfdoc/doc_form.cpp | 3 | ||||
| -rw-r--r-- | core/src/fpdfdoc/doc_link.cpp | 2 | ||||
| -rw-r--r-- | core/src/fpdfdoc/doc_tagged.cpp | 2 | ||||
| -rw-r--r-- | core/src/fpdfdoc/doc_utils.cpp | 1 |
5 files changed, 10 insertions, 0 deletions
diff --git a/core/src/fpdfdoc/doc_action.cpp b/core/src/fpdfdoc/doc_action.cpp index 9a0ba57951..12ec4c1907 100644 --- a/core/src/fpdfdoc/doc_action.cpp +++ b/core/src/fpdfdoc/doc_action.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <vector> + #include "core/include/fpdfapi/cpdf_document.h" #include "core/include/fpdfdoc/fpdf_doc.h" diff --git a/core/src/fpdfdoc/doc_form.cpp b/core/src/fpdfdoc/doc_form.cpp index 8080dc7597..7469cfd28f 100644 --- a/core/src/fpdfdoc/doc_form.cpp +++ b/core/src/fpdfdoc/doc_form.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <vector> + #include "core/include/fpdfapi/cpdf_document.h" #include "core/include/fpdfdoc/fpdf_doc.h" #include "core/src/fpdfdoc/doc_utils.h" @@ -385,6 +387,7 @@ static FX_BOOL RetrieveSpecificFont(uint8_t charSet, lf.lfCharSet = charSet; lf.lfPitchAndFamily = pitchAndFamily; if (pcsFontName) { + // TODO(dsinclair): Should this be strncpy? strcpy(lf.lfFaceName, pcsFontName); } return RetrieveSpecificFont(lf); diff --git a/core/src/fpdfdoc/doc_link.cpp b/core/src/fpdfdoc/doc_link.cpp index 7da29e0954..d2fe67df43 100644 --- a/core/src/fpdfdoc/doc_link.cpp +++ b/core/src/fpdfdoc/doc_link.cpp @@ -6,6 +6,8 @@ #include "core/include/fpdfdoc/fpdf_doc.h" +#include <vector> + CPDF_LinkList::CPDF_LinkList() { } diff --git a/core/src/fpdfdoc/doc_tagged.cpp b/core/src/fpdfdoc/doc_tagged.cpp index d4ce4a4b31..6eb1c98592 100644 --- a/core/src/fpdfdoc/doc_tagged.cpp +++ b/core/src/fpdfdoc/doc_tagged.cpp @@ -4,6 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include <map> + #include "core/include/fpdfapi/cpdf_document.h" #include "core/include/fpdfapi/fpdf_page.h" #include "core/include/fpdfapi/fpdf_parser.h" diff --git a/core/src/fpdfdoc/doc_utils.cpp b/core/src/fpdfdoc/doc_utils.cpp index bc09c9a2c4..11359c9129 100644 --- a/core/src/fpdfdoc/doc_utils.cpp +++ b/core/src/fpdfdoc/doc_utils.cpp @@ -5,6 +5,7 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include <algorithm> +#include <vector> #include "core/include/fpdfapi/cpdf_document.h" #include "core/include/fpdfdoc/fpdf_doc.h" |