diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2015-10-29 14:56:26 -0400 |
|---|---|---|
| committer | Dan Sinclair <dsinclair@chromium.org> | 2015-10-29 14:56:26 -0400 |
| commit | 589f7e0a57675efce9810c15a3e9b7c49bf0bc90 (patch) | |
| tree | 6839707c05c00f227744ffc3788665cb1cb5b7bd /core/src/fpdftext/fpdf_text.cpp | |
| parent | 6ed0028f1cf12ee53e9e7f657b7ba186c77a42f3 (diff) | |
| download | pdfium-589f7e0a57675efce9810c15a3e9b7c49bf0bc90.tar.xz | |
Cleanup some numeric code.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415933005 .
Diffstat (limited to 'core/src/fpdftext/fpdf_text.cpp')
| -rw-r--r-- | core/src/fpdftext/fpdf_text.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/core/src/fpdftext/fpdf_text.cpp b/core/src/fpdftext/fpdf_text.cpp index 9ecbc21bda..e9ad338025 100644 --- a/core/src/fpdftext/fpdf_text.cpp +++ b/core/src/fpdftext/fpdf_text.cpp @@ -436,10 +436,8 @@ void NormalizeString(CFX_WideString& str) { static FX_BOOL IsNumber(CFX_WideString& str) { for (int i = 0; i < str.GetLength(); i++) { FX_WCHAR ch = str[i]; - if ((ch < '0' || ch > '9') && ch != '-' && ch != '+' && ch != '.' && - ch != ' ') { + if (!std::isdigit(ch) && ch != '-' && ch != '+' && ch != '.' && ch != ' ') return FALSE; - } } return TRUE; } |