diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:28:50 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:28:50 -0700 |
| commit | 71c15a5e6652952a94ba3a3ef7ac0392e3a06962 (patch) | |
| tree | c6983e985c49e4f30906082b73045db14d8cb481 /core/src/fpdftext/unicodenormalization.cpp | |
| parent | a2b3ae23556fb2f1adbc008574f33bf365476af9 (diff) | |
| download | pdfium-71c15a5e6652952a94ba3a3ef7ac0392e3a06962.tar.xz | |
Extern in .cpp files is a code smell.
Part 1. Move to headers so compiler can type check against
the definitions.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1299963002 .
Diffstat (limited to 'core/src/fpdftext/unicodenormalization.cpp')
| -rw-r--r-- | core/src/fpdftext/unicodenormalization.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/core/src/fpdftext/unicodenormalization.cpp b/core/src/fpdftext/unicodenormalization.cpp index 446c6940eb..a7732967eb 100644 --- a/core/src/fpdftext/unicodenormalization.cpp +++ b/core/src/fpdftext/unicodenormalization.cpp @@ -5,15 +5,15 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include "../../include/fxcrt/fx_string.h" +#include "unicodenormalizationdata.h" + +const FX_WCHAR* const g_UnicodeData_Normalization_Maps[5] = { + nullptr, + g_UnicodeData_Normalization_Map1, + g_UnicodeData_Normalization_Map2, + g_UnicodeData_Normalization_Map3, + g_UnicodeData_Normalization_Map4}; -extern const FX_WCHAR g_UnicodeData_Normalization[]; -extern const FX_WCHAR g_UnicodeData_Normalization_Map1[]; -extern const FX_WCHAR g_UnicodeData_Normalization_Map2[]; -extern const FX_WCHAR g_UnicodeData_Normalization_Map3[]; -extern const FX_WCHAR g_UnicodeData_Normalization_Map4[]; -const FX_WCHAR* g_UnicodeData_Normalization_Maps[5] = { - NULL, g_UnicodeData_Normalization_Map1, g_UnicodeData_Normalization_Map2, - g_UnicodeData_Normalization_Map3, g_UnicodeData_Normalization_Map4}; FX_STRSIZE FX_Unicode_GetNormalization(FX_WCHAR wch, FX_WCHAR* pDst) { wch = wch & 0xFFFF; FX_WCHAR wFind = g_UnicodeData_Normalization[wch]; |