diff options
| author | Tom Sepez <tsepez@chromium.org> | 2014-08-13 17:12:28 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2014-08-13 17:12:28 -0700 |
| commit | 368ed462dd6e5e63977ca2b2e56a7e83b3a3bdda (patch) | |
| tree | d6e9f37c824646a245d2753fe93a8404da52dbff /core/src/fxcrt/fx_arabic.h | |
| parent | 2fd7b0be4473f4c9877fed2c2ade403c71ded395 (diff) | |
| download | pdfium-368ed462dd6e5e63977ca2b2e56a7e83b3a3bdda.tar.xz | |
Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes.
Should there be cases where this fails to compile, it indicates a mistake,
either an incorrectly declared overrriden virtual method, or a method that
should be declared non-virtual.
The only issues were with CPDF_CustomAccess::GetBlock(), CPDF_CustomAccess::GetByte(),
and CPDF_CustomAccess::GetFullPath(). These don't appear to be used anywhere,
and are removed. Two members are removed that are no longer needed once those
methods are removed.
R=jam@chromium.org, jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/454983003
Diffstat (limited to 'core/src/fxcrt/fx_arabic.h')
| -rw-r--r-- | core/src/fxcrt/fx_arabic.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/core/src/fxcrt/fx_arabic.h b/core/src/fxcrt/fx_arabic.h index 1dc275b8c3..c404449af0 100644 --- a/core/src/fxcrt/fx_arabic.h +++ b/core/src/fxcrt/fx_arabic.h @@ -10,18 +10,18 @@ class CFX_BidiChar FX_FINAL : public IFX_BidiChar, public CFX_Object { public: CFX_BidiChar(); - virtual void Release() + virtual void Release() FX_OVERRIDE { delete this; } - virtual void SetPolicy(FX_BOOL bSeparateNeutral = TRUE) + virtual void SetPolicy(FX_BOOL bSeparateNeutral = TRUE) FX_OVERRIDE { m_bSeparateNeutral = bSeparateNeutral; } - virtual FX_BOOL AppendChar(FX_WCHAR wch); - virtual FX_BOOL EndChar(); - virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount); - virtual void Reset(); + virtual FX_BOOL AppendChar(FX_WCHAR wch) FX_OVERRIDE; + virtual FX_BOOL EndChar() FX_OVERRIDE; + virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) FX_OVERRIDE; + virtual void Reset() FX_OVERRIDE; protected: FX_BOOL m_bSeparateNeutral; FX_INT32 m_iCurStart; |