diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-04-28 12:25:39 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-04-28 12:25:39 -0700 |
| commit | 5a256ad29483eb2b13e6e2c89fe0f77a9103f68f (patch) | |
| tree | ff77b2c74d95216b3f885f74052d0b0562ae8c02 /core/src/fxcrt | |
| parent | 00948f58ae4ba3713e2e25080c9e229ecbe929eb (diff) | |
| download | pdfium-5a256ad29483eb2b13e6e2c89fe0f77a9103f68f.tar.xz | |
Make CFX_WideString::LockBuffer() completely unused.
Then remove CFX_{Wide,Byte}String::LockBuffer(). Prelude to a vast
simplification. There's an additional copy now in one place, so
shoot me.
BUG=pdfium:144
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/ee7412f5aef353e5c6f1a64d0e1708ed926869d9
Review URL: https://codereview.chromium.org/1053613004
Diffstat (limited to 'core/src/fxcrt')
| -rw-r--r-- | core/src/fxcrt/fx_basic_bstring.cpp | 9 | ||||
| -rw-r--r-- | core/src/fxcrt/fx_basic_wstring.cpp | 9 |
2 files changed, 0 insertions, 18 deletions
diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp index cda7d1fdd7..961aebe69c 100644 --- a/core/src/fxcrt/fx_basic_bstring.cpp +++ b/core/src/fxcrt/fx_basic_bstring.cpp @@ -341,15 +341,6 @@ void CFX_ByteString::ReleaseBuffer(FX_STRSIZE nNewLength) m_pData->m_nDataLength = nNewLength; m_pData->m_String[nNewLength] = 0; } -FX_LPSTR CFX_ByteString::LockBuffer() -{ - if (m_pData == NULL) { - return NULL; - } - FX_LPSTR lpsz = GetBuffer(0); - m_pData->m_nRefs = -1; - return lpsz; -} void CFX_ByteString::Reserve(FX_STRSIZE len) { GetBuffer(len); diff --git a/core/src/fxcrt/fx_basic_wstring.cpp b/core/src/fxcrt/fx_basic_wstring.cpp index e255aa0779..2ea23e4f19 100644 --- a/core/src/fxcrt/fx_basic_wstring.cpp +++ b/core/src/fxcrt/fx_basic_wstring.cpp @@ -535,15 +535,6 @@ int CFX_WideString::Compare(const CFX_WideString& str) const } return 0; } -FX_LPWSTR CFX_WideString::LockBuffer() -{ - if (m_pData == NULL) { - return NULL; - } - FX_LPWSTR lpsz = GetBuffer(0); - m_pData->m_nRefs = -1; - return lpsz; -} void CFX_WideString::SetAt(FX_STRSIZE nIndex, FX_WCHAR ch) { if (m_pData == NULL) { |