diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-04-14 12:54:38 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-04-14 12:54:38 -0700 |
| commit | 4926900ab54a493d236291b5a24dfa4476792182 (patch) | |
| tree | e53800a0569300516c934bfccbb036ce39d98cb3 /core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h | |
| parent | eddab4425614e49146f904f00da4a664ba4b581b (diff) | |
| download | pdfium-4926900ab54a493d236291b5a24dfa4476792182.tar.xz | |
Kill CFX_Object.
CFX_Object is a type that implements its own new operators that return
NULL on error. There's no need for this given the |new (std::nothrow)|
syntax; in fact, the current code can only work if there is no activity
in the constructors. This may explain the pervasive lack of
constructors and reliance on Init() methods throughout the codebase.
The activity takes place in fx_memory.h, where FX_NEW is mapped onto
the std::nothrow syntax. The rest is just cleanup.
Down the road, we will simply throw and remove all the error-checking
paths for new objects. Landing this patch first will at least show a
simple path back to the old behaviour without having to re-introduce
CFX_Object should someone want to do so in their own fork.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1088733002
Diffstat (limited to 'core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h')
| -rw-r--r-- | core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h b/core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h index e9f0defbe8..e06322c24d 100644 --- a/core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h +++ b/core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h @@ -46,7 +46,7 @@ inline int poly_coord(FX_FLOAT c) { return int(c * poly_base_size); } -struct cell_aa : public CFX_Object { +struct cell_aa { int x; int y; int cover; @@ -56,7 +56,7 @@ struct cell_aa : public CFX_Object { void set_cover(int c, int a); void add_cover(int c, int a); }; -class outline_aa : public CFX_Object +class outline_aa { enum cell_block_scale_e { cell_block_shift = 12, @@ -65,7 +65,7 @@ class outline_aa : public CFX_Object cell_block_pool = 256, cell_block_limit = 1024 }; - struct sorted_y : public CFX_Object { + struct sorted_y { unsigned start; unsigned num; }; @@ -134,7 +134,7 @@ private: int m_max_y; bool m_sorted; }; -class scanline_hit_test : public CFX_Object +class scanline_hit_test { public: scanline_hit_test(int x) : m_x(x), m_hit(false) {} @@ -168,7 +168,7 @@ enum filling_rule_e { fill_non_zero, fill_even_odd }; -class rasterizer_scanline_aa : public CFX_Object +class rasterizer_scanline_aa { enum status { status_initial, |