diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-04-14 12:54:38 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-04-14 12:54:38 -0700 |
| commit | 4926900ab54a493d236291b5a24dfa4476792182 (patch) | |
| tree | e53800a0569300516c934bfccbb036ce39d98cb3 /core/src/fxge/dib | |
| parent | eddab4425614e49146f904f00da4a664ba4b581b (diff) | |
| download | pdfium-4926900ab54a493d236291b5a24dfa4476792182.tar.xz | |
Kill CFX_Object.
CFX_Object is a type that implements its own new operators that return
NULL on error. There's no need for this given the |new (std::nothrow)|
syntax; in fact, the current code can only work if there is no activity
in the constructors. This may explain the pervasive lack of
constructors and reliance on Init() methods throughout the codebase.
The activity takes place in fx_memory.h, where FX_NEW is mapped onto
the std::nothrow syntax. The rest is just cleanup.
Down the road, we will simply throw and remove all the error-checking
paths for new objects. Landing this patch first will at least show a
simple path back to the old behaviour without having to re-introduce
CFX_Object should someone want to do so in their own fork.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1088733002
Diffstat (limited to 'core/src/fxge/dib')
| -rw-r--r-- | core/src/fxge/dib/dib_int.h | 6 | ||||
| -rw-r--r-- | core/src/fxge/dib/fx_dib_convert.cpp | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/core/src/fxge/dib/dib_int.h b/core/src/fxge/dib/dib_int.h index 19dc358133..844c3566ce 100644 --- a/core/src/fxge/dib/dib_int.h +++ b/core/src/fxge/dib/dib_int.h @@ -7,7 +7,7 @@ #ifndef _DIB_INT_H_ #define _DIB_INT_H_ -class CPDF_FixedMatrix : public CFX_Object +class CPDF_FixedMatrix { public: CPDF_FixedMatrix(const CFX_AffineMatrix& src, int bits) @@ -34,7 +34,7 @@ struct PixelWeight { int m_SrcEnd; int m_Weights[1]; }; -class CWeightTable : public CFX_Object +class CWeightTable { public: CWeightTable() @@ -56,7 +56,7 @@ public: int m_DestMin, m_ItemSize; FX_LPBYTE m_pWeightTables; }; -class CStretchEngine : public CFX_Object +class CStretchEngine { public: CStretchEngine(IFX_ScanlineComposer* pDestBitmap, FXDIB_Format dest_format, diff --git a/core/src/fxge/dib/fx_dib_convert.cpp b/core/src/fxge/dib/fx_dib_convert.cpp index ddc24cc4ad..cfcbc707cd 100644 --- a/core/src/fxge/dib/fx_dib_convert.cpp +++ b/core/src/fxge/dib/fx_dib_convert.cpp @@ -97,7 +97,7 @@ const FX_DWORD g_dwMacPalette[256] = { 0xffEEEEEE, 0xffDDDDDD, 0xffBBBBBB, 0xffAAAAAA, 0xff888888, 0xff777777, 0xff555555, 0xff444444, 0xff222222, 0xff111111, 0xff000000 }; -class CFX_Palette : public CFX_Object +class CFX_Palette { public: CFX_Palette(); |