summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2015-10-16 16:21:58 -0700
committerLei Zhang <thestig@chromium.org>2015-10-16 16:21:58 -0700
commit316e482630d5f5d9084edd9725f98a0d89a5bbdf (patch)
treed0da57af48d88a18e0cd7dca9093057316da4078 /core
parent3d7d1d2f29e5fb099367a40822684d31f684fd62 (diff)
downloadpdfium-316e482630d5f5d9084edd9725f98a0d89a5bbdf.tar.xz
Don't bother passing -1 as the length to the CFX_ByteString ctor.
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1406363002 .
Diffstat (limited to 'core')
-rw-r--r--core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp2
-rw-r--r--core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp2
-rw-r--r--core/src/fpdftext/fpdf_text.cpp10
-rw-r--r--core/src/fxge/ge/fx_ge_fontmap.cpp2
-rw-r--r--core/src/fxge/win32/fx_win32_device.cpp2
5 files changed, 6 insertions, 12 deletions
diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
index dc79de687d..9c1c292fb7 100644
--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
@@ -1108,7 +1108,7 @@ CPDF_Dictionary* CPDF_Document::CreateNewPage(int iPage) {
CPDF_Font* CPDF_Document::AddStandardFont(const FX_CHAR* font,
CPDF_FontEncoding* pEncoding) {
- CFX_ByteString name(font, -1);
+ CFX_ByteString name(font);
if (PDF_GetStandardFontName(&name) < 0)
return nullptr;
return GetPageData()->GetStandardFont(name, pEncoding);
diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp
index 308dac9782..92d1719efe 100644
--- a/core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp
+++ b/core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp
@@ -1778,5 +1778,5 @@ FX_WCHAR PDF_UnicodeFromAdobeName(const FX_CHAR* name) {
CFX_ByteString PDF_AdobeNameFromUnicode(FX_WCHAR unicode) {
char glyph_name[64];
FXFT_adobe_name_from_unicode(glyph_name, unicode);
- return CFX_ByteString(glyph_name, -1);
+ return CFX_ByteString(glyph_name);
}
diff --git a/core/src/fpdftext/fpdf_text.cpp b/core/src/fpdftext/fpdf_text.cpp
index 40f5dd4926..9ecbc21bda 100644
--- a/core/src/fpdftext/fpdf_text.cpp
+++ b/core/src/fpdftext/fpdf_text.cpp
@@ -22,10 +22,7 @@ CFX_ByteString CharFromUnicodeAlt(FX_WCHAR unicode,
return CFX_ByteString((char)unicode);
}
const FX_CHAR* altstr = FCS_GetAltStr(unicode);
- if (altstr) {
- return CFX_ByteString(altstr, -1);
- }
- return CFX_ByteString(defchar, -1);
+ return CFX_ByteString(altstr ? altstr : defchar);
}
char buf[10];
int iDef = 0;
@@ -35,10 +32,7 @@ CFX_ByteString CharFromUnicodeAlt(FX_WCHAR unicode,
return CFX_ByteString(buf, ret);
}
const FX_CHAR* altstr = FCS_GetAltStr(unicode);
- if (altstr) {
- return CFX_ByteString(altstr, -1);
- }
- return CFX_ByteString(defchar, -1);
+ return CFX_ByteString(altstr ? altstr : defchar);
}
CTextPage::CTextPage() {}
CTextPage::~CTextPage() {
diff --git a/core/src/fxge/ge/fx_ge_fontmap.cpp b/core/src/fxge/ge/fx_ge_fontmap.cpp
index 061ad66dd0..e88791aac5 100644
--- a/core/src/fxge/ge/fx_ge_fontmap.cpp
+++ b/core/src/fxge/ge/fx_ge_fontmap.cpp
@@ -455,7 +455,7 @@ void CFX_FontMapper::SetSystemFontInfo(IFX_SystemFontInfo* pFontInfo) {
m_pFontInfo = pFontInfo;
}
static CFX_ByteString _TT_NormalizeName(const FX_CHAR* family) {
- CFX_ByteString norm(family, -1);
+ CFX_ByteString norm(family);
norm.Remove(' ');
norm.Remove('-');
norm.Remove(',');
diff --git a/core/src/fxge/win32/fx_win32_device.cpp b/core/src/fxge/win32/fx_win32_device.cpp
index a40e79bde7..93c2fd6836 100644
--- a/core/src/fxge/win32/fx_win32_device.cpp
+++ b/core/src/fxge/win32/fx_win32_device.cpp
@@ -122,7 +122,7 @@ FX_BOOL CFX_Win32FontInfo::IsSupportFontFormDiv(const LOGFONTA* plf) {
}
void CFX_Win32FontInfo::AddInstalledFont(const LOGFONTA* plf,
FX_DWORD FontType) {
- CFX_ByteString name(plf->lfFaceName, -1);
+ CFX_ByteString name(plf->lfFaceName);
if (name[0] == '@') {
return;
}