summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorjaepark <jaepark@google.com>2016-07-15 19:25:27 -0700
committerCommit bot <commit-bot@chromium.org>2016-07-15 19:25:28 -0700
commit8d5315004400be520bd988c1789e3b0a800fb100 (patch)
tree3e60e3f2b8f0ecc2a8726f8a3b58f821ea1de7f3 /core
parent40faa79da0bc902d7f1f5cc43464b94e6dfa5d22 (diff)
downloadpdfium-8d5315004400be520bd988c1789e3b0a800fb100.tar.xz
Use CPDF_Dictionary::SetAtReference instead of CPDF_Dictionary::AddReference.
The definitions of CPDF_Dictionary::SetAtReference and CPDF_Dictionary::AddReference are identical, and AddReference is only used once. So remove CPDF_Dictionary::AddReference method and use CPDF_Dictionary::SetAtReference instead. Review-Url: https://codereview.chromium.org/2161453002
Diffstat (limited to 'core')
-rw-r--r--core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp2
-rw-r--r--core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp6
-rw-r--r--core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h4
3 files changed, 1 insertions, 11 deletions
diff --git a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
index 7ddc211671..0b87e75f62 100644
--- a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
+++ b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
@@ -81,7 +81,7 @@ CFX_ByteString CPDF_PageContentGenerator::RealizeResource(
}
idnum++;
}
- pResList->AddReference(name, m_pDocument, pResourceObj->GetObjNum());
+ pResList->SetAtReference(name, m_pDocument, pResourceObj->GetObjNum());
return name;
}
void CPDF_PageContentGenerator::ProcessImage(CFX_ByteTextBuf& buf,
diff --git a/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp b/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp
index 4ea8f438bd..78b88a1b2f 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp
+++ b/core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp
@@ -214,12 +214,6 @@ void CPDF_Dictionary::SetAtReference(const CFX_ByteString& key,
SetAt(key, new CPDF_Reference(pDoc, objnum));
}
-void CPDF_Dictionary::AddReference(const CFX_ByteString& key,
- CPDF_IndirectObjectHolder* pDoc,
- uint32_t objnum) {
- SetAt(key, new CPDF_Reference(pDoc, objnum));
-}
-
void CPDF_Dictionary::SetAtNumber(const CFX_ByteString& key, FX_FLOAT f) {
SetAt(key, new CPDF_Number(f));
}
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
index 41cec0cda2..29846366d9 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h
@@ -71,10 +71,6 @@ class CPDF_Dictionary : public CPDF_Object {
void SetAtMatrix(const CFX_ByteString& key, const CFX_Matrix& matrix);
void SetAtBoolean(const CFX_ByteString& key, bool bValue);
- void AddReference(const CFX_ByteString& key,
- CPDF_IndirectObjectHolder* pDoc,
- uint32_t objnum);
-
// Invalidates iterators for the element with the key |key|.
void RemoveAt(const CFX_ByteString& key);