summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2017-11-07 20:38:20 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-07 20:38:20 +0000
commitc5a729ec5ada8ef0edc3f4d9976e96865f516598 (patch)
tree52b5f9178d0c6c0726f97a2f9032824cba9d9659 /core
parent9fed656915010adf6003017bc2e3c353668f9dc5 (diff)
downloadpdfium-c5a729ec5ada8ef0edc3f4d9976e96865f516598.tar.xz
Revert cleanup of IsHyphen and reimplement
The original version of this code was landed in https://pdfium-review.googlesource.com/c/pdfium/+/13690/. A corner case has been found that breaks. In this CL I have reverted the changes in IsHyphen and implemented a less aggressive cleanup that I have tested works as expected. BUG=chromium:781804 Change-Id: I3b36f420834081fdd9e1ae17efc234b561b4df41 Reviewed-on: https://pdfium-review.googlesource.com/17950 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core')
-rw-r--r--core/fpdftext/cpdf_textpage.cpp32
1 files changed, 18 insertions, 14 deletions
diff --git a/core/fpdftext/cpdf_textpage.cpp b/core/fpdftext/cpdf_textpage.cpp
index b4f879aec5..6ccadff701 100644
--- a/core/fpdftext/cpdf_textpage.cpp
+++ b/core/fpdftext/cpdf_textpage.cpp
@@ -1218,25 +1218,29 @@ CPDF_TextPage::TextOrientation CPDF_TextPage::GetTextObjectWritingMode(
}
bool CPDF_TextPage::IsHyphen(wchar_t curChar) const {
- WideStringView curText;
- if (!m_TempTextBuf.IsEmpty())
- curText = m_TempTextBuf.AsStringView();
- else if (!m_TextBuf.IsEmpty())
+ WideStringView curText = m_TempTextBuf.AsStringView();
+ if (curText.IsEmpty())
curText = m_TextBuf.AsStringView();
- else
- return false;
- curText = curText.TrimmedRight(0x20);
- if (curText.GetLength() < 2)
+ if (curText.IsEmpty())
return false;
- // Extracting the last 2 characters, since they are all that matter
- curText = curText.Right(2);
- if (!IsHyphenCode(curText.Last()))
- return false;
+ auto iter = curText.rbegin();
+ for (; iter != curText.rend() && *iter == 0x20; iter++) {
+ // Do nothing
+ }
- if (FXSYS_iswalpha(curText.First() && FXSYS_iswalnum(curChar)))
- return true;
+ if (iter != curText.rend()) {
+ if (!IsHyphenCode(*iter))
+ return false;
+ iter++;
+ if (FXSYS_iswalpha(*iter) && FXSYS_iswalpha(*iter))
+ return true;
+ } else {
+ iter--;
+ if (!IsHyphenCode(*iter))
+ return false;
+ }
const PAGECHAR_INFO* preInfo;
if (!m_TempCharList.empty())