diff options
author | dan sinclair <dsinclair@chromium.org> | 2018-04-16 17:07:27 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-16 17:07:27 +0000 |
commit | b7475313178d2f8db39e4179a202e8c920651ede (patch) | |
tree | f1bd44cee8a61af2c269aaeb4022a8eb0749c03a /core | |
parent | 19ae9bf554fc1c01e352a846646c8005a4fe6b2b (diff) | |
download | pdfium-b7475313178d2f8db39e4179a202e8c920651ede.tar.xz |
Remove CPWL_Edit rich text support
This CL removes the code which attempts to provide rich text support for
CPWL_Edit. The code, as written, doesn't actually work well.
If you have tags under the <p> tag we will just lose the content (so
<p><b>foo</b></p> would end up being a blank string).
Multiple <p> tags get concatenated together with a \n, but we
subsequently lose the \n later when we store the content into the
VariableText object (so <p>foo</p><p>bar</p> becomes foobar instead
of foo\nbar).
We never read the "RV" field from the dictionary. The RV field is what
actually stores the rich text value. So, we never set a rich text
value into the text edit.
Change-Id: Idc1d65e1b5d75380dd28c45bcbf9137a2a4cea9a
Reviewed-on: https://pdfium-review.googlesource.com/30690
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core')
-rw-r--r-- | core/fpdfdoc/cpdf_formfield.cpp | 5 | ||||
-rw-r--r-- | core/fpdfdoc/cpdf_formfield.h | 1 |
2 files changed, 0 insertions, 6 deletions
diff --git a/core/fpdfdoc/cpdf_formfield.cpp b/core/fpdfdoc/cpdf_formfield.cpp index 540e1c9ae0..ae10b9e39d 100644 --- a/core/fpdfdoc/cpdf_formfield.cpp +++ b/core/fpdfdoc/cpdf_formfield.cpp @@ -289,11 +289,6 @@ ByteString CPDF_FormField::GetDefaultStyle() const { return pObj ? pObj->GetString() : ""; } -WideString CPDF_FormField::GetRichTextString() const { - CPDF_Object* pObj = FPDF_GetFieldAttr(m_pDict.Get(), "RV"); - return pObj ? pObj->GetUnicodeText() : L""; -} - WideString CPDF_FormField::GetValue(bool bDefault) const { if (GetType() == CheckBox || GetType() == RadioButton) return GetCheckValue(bDefault); diff --git a/core/fpdfdoc/cpdf_formfield.h b/core/fpdfdoc/cpdf_formfield.h index 4f25465b43..b79e430dee 100644 --- a/core/fpdfdoc/cpdf_formfield.h +++ b/core/fpdfdoc/cpdf_formfield.h @@ -129,7 +129,6 @@ class CPDF_FormField { uint32_t GetFieldFlags() const; ByteString GetDefaultStyle() const; - WideString GetRichTextString() const; WideString GetValue() const; WideString GetDefaultValue() const; |