diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-02-15 18:12:29 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-15 18:12:29 +0000 |
| commit | e40678ed8a22ecd57421877af39cf7f281f618c4 (patch) | |
| tree | 50bbf114829ad3b4852b3739f65c6385091c4ba0 /core | |
| parent | 625e6fec9ddd1d023116f7bd22d2192ef9bc49c8 (diff) | |
| download | pdfium-e40678ed8a22ecd57421877af39cf7f281f618c4.tar.xz | |
Make the CFX_XMLNode a MaybeOwned pointer
This CL removes the HasOwnXML flag from the CXFA_Node objects and
instead uses a MaybeOwned pointer to keep track of the XML nodes.
Change-Id: Ie678258247ec21ecb15c639647b189e140586d25
Reviewed-on: https://pdfium-review.googlesource.com/26811
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core')
| -rw-r--r-- | core/fxcrt/maybe_owned.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/core/fxcrt/maybe_owned.h b/core/fxcrt/maybe_owned.h index 130d2bdc3c..d920ea7a91 100644 --- a/core/fxcrt/maybe_owned.h +++ b/core/fxcrt/maybe_owned.h @@ -41,6 +41,11 @@ class MaybeOwned { m_pObj = ptr; m_pOwnedObj.reset(); } + // Helpful for untangling a collection of intertwined MaybeOwned<>. + void ResetIfUnowned() { + if (!IsOwned()) + Reset(); + } T* Get() const { return m_pObj.Get(); } bool IsOwned() const { return !!m_pOwnedObj; } |