summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authordan sinclair <dsinclair@chromium.org>2018-03-08 15:13:19 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-03-08 15:13:19 +0000
commitf19255a1deec5f3ce804b08901abf7746e609bfe (patch)
tree51548e2c51d8b94ac0dc445eae2af1dc1cd90901 /core
parent4ce3f6e8bdb64624435620e606513d6aba1cafc8 (diff)
downloadpdfium-f19255a1deec5f3ce804b08901abf7746e609bfe.tar.xz
Remove BeforeFormImportData and BeforeFormReset
Both of these IPDF_FormNotify callbacks have empty implementations which just return 0. Removed. Change-Id: I3324113222f19d2f7a2323ab5086e446d2064451 Reviewed-on: https://pdfium-review.googlesource.com/28191 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core')
-rw-r--r--core/fpdfdoc/cpdf_interform.cpp6
-rw-r--r--core/fpdfdoc/ipdf_formnotify.h4
2 files changed, 2 insertions, 8 deletions
diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp
index 1596b17d82..c8440eac00 100644
--- a/core/fpdfdoc/cpdf_interform.cpp
+++ b/core/fpdfdoc/cpdf_interform.cpp
@@ -901,9 +901,6 @@ int CPDF_InterForm::GetFormAlignment() const {
bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
bool bIncludeOrExclude,
bool bNotify) {
- if (bNotify && m_pFormNotify && m_pFormNotify->BeforeFormReset(this) < 0)
- return false;
-
size_t nCount = m_pFieldTree->m_Root.CountFields();
for (size_t i = 0; i < nCount; ++i) {
CPDF_FormField* pField = m_pFieldTree->m_Root.GetFieldAtIndex(i);
@@ -919,9 +916,6 @@ bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
}
bool CPDF_InterForm::ResetForm(bool bNotify) {
- if (bNotify && m_pFormNotify && m_pFormNotify->BeforeFormReset(this) < 0)
- return false;
-
size_t nCount = m_pFieldTree->m_Root.CountFields();
for (size_t i = 0; i < nCount; ++i) {
CPDF_FormField* pField = m_pFieldTree->m_Root.GetFieldAtIndex(i);
diff --git a/core/fpdfdoc/ipdf_formnotify.h b/core/fpdfdoc/ipdf_formnotify.h
index 301139b433..10a97a0d88 100644
--- a/core/fpdfdoc/ipdf_formnotify.h
+++ b/core/fpdfdoc/ipdf_formnotify.h
@@ -19,13 +19,13 @@ class IPDF_FormNotify {
virtual int BeforeValueChange(CPDF_FormField* pField,
const WideString& csValue) = 0;
virtual void AfterValueChange(CPDF_FormField* pField) = 0;
+
virtual int BeforeSelectionChange(CPDF_FormField* pField,
const WideString& csValue) = 0;
virtual void AfterSelectionChange(CPDF_FormField* pField) = 0;
+
virtual void AfterCheckedStatusChange(CPDF_FormField* pField) = 0;
- virtual int BeforeFormReset(CPDF_InterForm* pForm) = 0;
virtual void AfterFormReset(CPDF_InterForm* pForm) = 0;
- virtual int BeforeFormImportData(CPDF_InterForm* pForm) = 0;
};
#endif // CORE_FPDFDOC_IPDF_FORMNOTIFY_H_