diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-22 17:46:05 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-22 17:46:05 +0000 |
| commit | 9fff1c76c1083a5cc0543911811e36007a38aa3a (patch) | |
| tree | d7769c918bdf41a572d3869c5f2e3982636b50a0 /core | |
| parent | e6ca7c2d7d45bd59d53c3c6f9952e2001cf81890 (diff) | |
| download | pdfium-9fff1c76c1083a5cc0543911811e36007a38aa3a.tar.xz | |
Avoid some duplicate const/non-const getters.
Getters should nearly always be const when they return a
non-const pointer to an unowned object. Saves a bit of
code along the way.
Grep for similar occurrences and add "const".
Change-Id: I492bf962a7d62452fa40310146226dc0c8ebb753
Reviewed-on: https://pdfium-review.googlesource.com/35890
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core')
| -rw-r--r-- | core/fpdfapi/page/cpdf_pattern.h | 3 | ||||
| -rw-r--r-- | core/fpdfdoc/cpdf_formfield.h | 6 |
2 files changed, 3 insertions, 6 deletions
diff --git a/core/fpdfapi/page/cpdf_pattern.h b/core/fpdfapi/page/cpdf_pattern.h index f1d98922c7..307c677775 100644 --- a/core/fpdfapi/page/cpdf_pattern.h +++ b/core/fpdfapi/page/cpdf_pattern.h @@ -28,8 +28,7 @@ class CPDF_Pattern { // All the getters that return pointers return non-NULL pointers. CPDF_Document* document() const { return m_pDocument.Get(); } - CPDF_Object* pattern_obj() { return m_pPatternObj.Get(); } - const CPDF_Object* pattern_obj() const { return m_pPatternObj.Get(); } + CPDF_Object* pattern_obj() const { return m_pPatternObj.Get(); } CFX_Matrix* pattern_to_form() { return &m_Pattern2Form; } const CFX_Matrix& parent_matrix() const { return m_ParentMatrix; } diff --git a/core/fpdfdoc/cpdf_formfield.h b/core/fpdfdoc/cpdf_formfield.h index 78ef1798cb..0b570efccf 100644 --- a/core/fpdfdoc/cpdf_formfield.h +++ b/core/fpdfdoc/cpdf_formfield.h @@ -170,10 +170,8 @@ class CPDF_FormField { float GetFontSize() const { return m_FontSize; } CPDF_Font* GetFont() const { return m_pFont.Get(); } - const CPDF_Dictionary* GetDict() const { return m_pDict.Get(); } - CPDF_Dictionary* GetDict() { return m_pDict.Get(); } - - const CPDF_InterForm* GetForm() const { return m_pForm.Get(); } + CPDF_Dictionary* GetDict() const { return m_pDict.Get(); } + CPDF_InterForm* GetForm() const { return m_pForm.Get(); } WideString GetCheckValue(bool bDefault) const; |