summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2017-11-22 20:04:12 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-22 20:04:12 +0000
commitfe2cd4d914205f2da91286e7270209e2016d51a1 (patch)
tree50c8f98c7daf38df965f83e29a382fd95434195d /core
parentd328d91f9e7a49f0d79048a7d10be9ba17ad9cb2 (diff)
downloadpdfium-fe2cd4d914205f2da91286e7270209e2016d51a1.tar.xz
Remove some pointless assignments to "".
Or change them to clear(). Change-Id: Ia9e3e1f0d74b948cec3f8df85d205f830ac9216c Reviewed-on: https://pdfium-review.googlesource.com/19172 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core')
-rw-r--r--core/fpdfapi/parser/fpdf_parser_decode.cpp2
-rw-r--r--core/fpdfdoc/cpdf_interform.cpp2
-rw-r--r--core/fxge/win32/fx_win32_gdipext.cpp2
3 files changed, 3 insertions, 3 deletions
diff --git a/core/fpdfapi/parser/fpdf_parser_decode.cpp b/core/fpdfapi/parser/fpdf_parser_decode.cpp
index 7ad6c0176f..8a31643632 100644
--- a/core/fpdfapi/parser/fpdf_parser_decode.cpp
+++ b/core/fpdfapi/parser/fpdf_parser_decode.cpp
@@ -411,7 +411,7 @@ bool PDF_DataDecode(const uint8_t* src_buf,
last_buf = new_buf;
last_size = new_size;
}
- *ImageEncoding = "";
+ ImageEncoding->clear();
*pImageParms = nullptr;
*dest_buf = last_buf;
*dest_size = last_size;
diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp
index e42095c048..e71e16cddd 100644
--- a/core/fpdfdoc/cpdf_interform.cpp
+++ b/core/fpdfdoc/cpdf_interform.cpp
@@ -691,7 +691,7 @@ ByteString CPDF_InterForm::GenerateNewResourceName(
int iCount = csStr.GetLength();
int m = 0;
if (iMinLen > 0) {
- csTmp = "";
+ csTmp.clear();
while (m < iMinLen && m < iCount)
csTmp += csStr[m++];
while (m < iMinLen) {
diff --git a/core/fxge/win32/fx_win32_gdipext.cpp b/core/fxge/win32/fx_win32_gdipext.cpp
index 70da194be4..1a7e132c64 100644
--- a/core/fxge/win32/fx_win32_gdipext.cpp
+++ b/core/fxge/win32/fx_win32_gdipext.cpp
@@ -682,7 +682,7 @@ CGdiplusExt::CGdiplusExt() {
m_pGdiRemoveFontMemResourseEx = nullptr;
}
void CGdiplusExt::Load() {
- ByteString strPlusPath = "";
+ ByteString strPlusPath;
char buf[MAX_PATH];
GetSystemDirectoryA(buf, MAX_PATH);
strPlusPath += buf;