diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-06-02 00:45:14 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-06-02 18:31:20 +0000 |
| commit | 4f34c64914be17966f2d91591921dec635582061 (patch) | |
| tree | 762d9af8dd0aaeb084a007e6133418e56f6a7605 /fpdfsdk/formfiller/cffl_interactiveformfiller.cpp | |
| parent | dd29c258fbf7838ddd0ee99361beb4c2da8dce7f (diff) | |
| download | pdfium-4f34c64914be17966f2d91591921dec635582061.tar.xz | |
Clean up CFFL formfiller classes.
- Consolidate assertions for m_pFormFillEnv.
- Remove check for m_pFormFillEnv being NULL.
- Pass in a CPDFSDK_Widget* instead of an Annot* and then casting.
- Remove unused LoadPopupMenuString() method.
Change-Id: Ic22e75c9e41eb54002be812945a3ee80debeca8b
Reviewed-on: https://pdfium-review.googlesource.com/6232
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/formfiller/cffl_interactiveformfiller.cpp')
| -rw-r--r-- | fpdfsdk/formfiller/cffl_interactiveformfiller.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp index 491186e39c..2c75225283 100644 --- a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp +++ b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp @@ -478,7 +478,8 @@ CFFL_FormFiller* CFFL_InteractiveFormFiller::GetFormFiller( if (!bRegister) return nullptr; - CPDFSDK_Widget* pWidget = (CPDFSDK_Widget*)pAnnot; + // TODO(thestig): How do we know |pAnnot| is a CPDFSDK_Widget? + CPDFSDK_Widget* pWidget = static_cast<CPDFSDK_Widget*>(pAnnot); int nFieldType = pWidget->GetFieldType(); CFFL_FormFiller* pFormFiller; switch (nFieldType) { |