diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-26 20:49:16 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-26 20:49:16 +0000 |
| commit | 29d56a4476071b9aafd1fd7af725ee193bdec952 (patch) | |
| tree | 4ccffbb45939673d423b3504d3d877fc1ccfa8f0 /fpdfsdk/formfiller/cffl_listbox.cpp | |
| parent | 2cae3e26526a8aeef5744665589d1bfaf5efe6f3 (diff) | |
| download | pdfium-29d56a4476071b9aafd1fd7af725ee193bdec952.tar.xz | |
cp.pParentWindow is always NULL in NewPWLWindow()
Because the CreateParams come from one of the GetCreateParam()
overrides, and none of these set that particual field. This
implies that the caller will always own the result, since it
is never handed off by an AddChild() call, which is consistent
with the function return.
Change-Id: I1a9f580f347e911855c695807795541282d43f3f
Reviewed-on: https://pdfium-review.googlesource.com/c/44691
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/formfiller/cffl_listbox.cpp')
| -rw-r--r-- | fpdfsdk/formfiller/cffl_listbox.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fpdfsdk/formfiller/cffl_listbox.cpp b/fpdfsdk/formfiller/cffl_listbox.cpp index 335073293f..e601c8305e 100644 --- a/fpdfsdk/formfiller/cffl_listbox.cpp +++ b/fpdfsdk/formfiller/cffl_listbox.cpp @@ -43,8 +43,6 @@ std::unique_ptr<CPWL_Wnd> CFFL_ListBox::NewPWLWindow( const CPWL_Wnd::CreateParams& cp, std::unique_ptr<CPWL_Wnd::PrivateData> pAttachedData) { auto pWnd = pdfium::MakeUnique<CPWL_ListBox>(std::move(pAttachedData)); - if (cp.pParentWnd) - cp.pParentWnd->AddChild(pWnd.get()); pWnd->AttachFFLData(this); pWnd->Realize(cp); pWnd->SetFillerNotify(m_pFormFillEnv->GetInteractiveFormFiller()); |