diff options
author | Henrique Nakashima <hnakashima@chromium.org> | 2018-09-24 17:23:27 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-09-24 17:23:27 +0000 |
commit | 97f4483de007c2ff248696f24d34634e0adbf894 (patch) | |
tree | 7defaedcdad0f06b8a870164fd2bee9200b347ac /fpdfsdk/fpdf_formfill_embeddertest.cpp | |
parent | f07e487a1a6d5c1588b1d1dfd5c25fa5b91f73ca (diff) | |
download | pdfium-97f4483de007c2ff248696f24d34634e0adbf894.tar.xz |
Revert "Make potentially dangerous Actions require a user click."
This reverts commit 9d784c291714b703b16185e69860a3797de85b6c.
Reason for revert: Roll into chromium is stuck, this is a potential
culprit.
Original change's description:
> Make potentially dangerous Actions require a user click.
>
> URI and SubmitForm actions are only handled if the event was
> ButtonUp or ButtonDown.
>
> Bug: 851821
> Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
> Reviewed-on: https://pdfium-review.googlesource.com/42731
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
TBR=tsepez@chromium.org,hnakashima@chromium.org,rharrison@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851821
Change-Id: I6f1bc0a02f65a24fbd49d53526b985f8a4ea0b4f
Reviewed-on: https://pdfium-review.googlesource.com/42990
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdf_formfill_embeddertest.cpp')
-rw-r--r-- | fpdfsdk/fpdf_formfill_embeddertest.cpp | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/fpdfsdk/fpdf_formfill_embeddertest.cpp b/fpdfsdk/fpdf_formfill_embeddertest.cpp index 3e53753b48..8ff3a84291 100644 --- a/fpdfsdk/fpdf_formfill_embeddertest.cpp +++ b/fpdfsdk/fpdf_formfill_embeddertest.cpp @@ -379,25 +379,6 @@ TEST_F(FPDFFormFillEmbeddertest, BUG_514690) { UnloadPage(page); } -class DoURIActionBlockedDelegate final : public EmbedderTest::Delegate { - public: - void DoURIAction(FPDF_BYTESTRING uri) override { - FAIL() << "Navigated to " << uri; - } -}; - -TEST_F(FPDFFormFillEmbeddertest, BUG_851821) { - DoURIActionBlockedDelegate delegate; - SetDelegate(&delegate); - - EXPECT_TRUE(OpenDocument("redirect.pdf")); - FPDF_PAGE page = LoadPage(0); - EXPECT_TRUE(page); - DoOpenActions(); - - UnloadPage(page); -} - #ifdef PDF_ENABLE_V8 TEST_F(FPDFFormFillEmbeddertest, DisableJavaScript) { // Test that timers and intervals can't fire without JS. |